On Mon, Sep 11, 2023 at 11:41:12AM +0200, Krzysztof Kozlowski wrote:
> Missing reg. Probably also port.
Hello again,
I've been working on v2 of this series and done some initial cleanup.
Right now it looks a bit like this:
> allOf:
> - $ref: panel-common.yaml#
> - $ref: /schemas/spi/spi-peripheral-props.yaml#
>
> properties:
> compatible:
> const: fascontek,fs035vg158
>
> spi-3wire: true
>
> required:
> - compatible
> - reg
> - port
> - power-supply
> - reset-gpios
Does this seem correct?
- reg is required by spi-controller
- port is listed in panel-common
- power-supply is listed in panel-common
I'm guessing that the required section just lists the minimal
properties needed for this specific device tree yaml?
There's nothing implied by allOf?
> Best regards,
> Krzysztof
>
John Watts.
On 17/09/2023 22:24, John Watts wrote:
> On Mon, Sep 11, 2023 at 11:41:12AM +0200, Krzysztof Kozlowski wrote:
>> Missing reg. Probably also port.
>
> Hello again,
>
> I've been working on v2 of this series and done some initial cleanup.
>
> Right now it looks a bit like this:
>
>> allOf:
>> - $ref: panel-common.yaml#
>> - $ref: /schemas/spi/spi-peripheral-props.yaml#
>>
>> properties:
>> compatible:
>> const: fascontek,fs035vg158
>>
>> spi-3wire: true
>>
>> required:
>> - compatible
>> - reg
>> - port
>> - power-supply
>> - reset-gpios
>
> Does this seem correct?
> - reg is required by spi-controller
> - port is listed in panel-common
> - power-supply is listed in panel-common
>
> I'm guessing that the required section just lists the minimal
> properties needed for this specific device tree yaml?
> There's nothing implied by allOf?
Ah, then it is fine.
Best regards,
Krzysztof