2023-10-29 14:24:37

by Bagas Sanjaya

[permalink] [raw]
Subject: Re: [PATCH] Fix line Length

On Sun, Oct 29, 2023 at 01:51:04PM +0000, Dorine Tipo wrote:
>
> Fix the line lengths of lines 8 and 49
>

Is it checkpatch fix?

> Signed-off-by: Dorine Tipo <[email protected]>
> ---
> drivers/gpu/drm/ci/igt_runner.sh | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/ci/igt_runner.sh b/drivers/gpu/drm/ci/igt_runner.sh
> index 2bb759165063..d7b779bb7f64 100755
> --- a/drivers/gpu/drm/ci/igt_runner.sh
> +++ b/drivers/gpu/drm/ci/igt_runner.sh
> @@ -5,7 +5,8 @@ set -ex
>
> export IGT_FORCE_DRIVER=${DRIVER_NAME}
> export PATH=$PATH:/igt/bin/
> -export LD_LIBRARY_PATH=$LD_LIBRARY_PATH:/igt/lib/aarch64-linux-gnu/:/igt/lib/x86_64-linux-gnu:/igt/lib:/igt/lib64
> +export LD_LIBRARY_PATH=$LD_LIBRARY_PATH:/igt/lib/aarch64-linux-gnu/:/igt/lib/x86_64-linux-gnu
> +export LD_LIBRARY_PATH=$LD_LIBRARY_PATH:/igt/lib:/igt/lib64

I'd like the former (single-line) assignment version.

> -curl -L --retry 4 -f --retry-all-errors --retry-delay 60 -s ${FDO_HTTP_CACHE_URI:-}$PIPELINE_ARTIFACTS_BASE/$ARCH/igt.tar.gz | tar --zstd -v -x -C /
> +curl -L --retry 4 -f --retry-all-errors --retry-delay 60 -s \
> + ${FDO_HTTP_CACHE_URI:-}$PIPELINE_ARTIFACTS_BASE/$ARCH/igt.tar.gz | tar --zstd -v -x -C /

This one LGTM.

Thanks.

--
An old man doll... just what I always wanted! - Clara


Attachments:
(No filename) (1.33 kB)
signature.asc (235.00 B)
Download all attachments