2022-12-07 03:43:06

by ye.xingchen

[permalink] [raw]
Subject: [PATCH v2] i2c: mux: Convert to use sysfs_emit_at() API

From: ye xingchen <[email protected]>

Follow the advice of the Documentation/filesystems/sysfs.rst and show()
should only use sysfs_emit() or sysfs_emit_at() when formatting the
value to be returned to user space.

Signed-off-by: ye xingchen <[email protected]>
---
v1 -> v2
Fix the code style.
drivers/i2c/muxes/i2c-demux-pinctrl.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/i2c/muxes/i2c-demux-pinctrl.c b/drivers/i2c/muxes/i2c-demux-pinctrl.c
index f7a7405d4350..28e0911920be 100644
--- a/drivers/i2c/muxes/i2c-demux-pinctrl.c
+++ b/drivers/i2c/muxes/i2c-demux-pinctrl.c
@@ -167,9 +167,9 @@ static ssize_t available_masters_show(struct device *dev,
int count = 0, i;

for (i = 0; i < priv->num_chan && count < PAGE_SIZE; i++)
- count += scnprintf(buf + count, PAGE_SIZE - count, "%d:%pOF%c",
- i, priv->chan[i].parent_np,
- i == priv->num_chan - 1 ? '\n' : ' ');
+ count += sysfs_emit_at(buf, count, "%d:%pOF%c",
+ i, priv->chan[i].parent_np,
+ i == priv->num_chan - 1 ? '\n' : ' ');

return count;
}
--
2.25.1


2023-10-29 19:30:00

by Wolfram Sang

[permalink] [raw]
Subject: Re: [PATCH v2] i2c: mux: Convert to use sysfs_emit_at() API

On Wed, Dec 07, 2022 at 10:48:33AM +0800, [email protected] wrote:
> From: ye xingchen <[email protected]>
>
> Follow the advice of the Documentation/filesystems/sysfs.rst and show()
> should only use sysfs_emit() or sysfs_emit_at() when formatting the
> value to be returned to user space.
>
> Signed-off-by: ye xingchen <[email protected]>

Tested-by: Wolfram Sang <[email protected]>


Attachments:
(No filename) (431.00 B)
signature.asc (849.00 B)
Download all attachments

2023-10-29 19:30:23

by Wolfram Sang

[permalink] [raw]
Subject: Re: [PATCH v2] i2c: mux: Convert to use sysfs_emit_at() API

On Wed, Dec 07, 2022 at 10:48:33AM +0800, [email protected] wrote:
> From: ye xingchen <[email protected]>
>
> Follow the advice of the Documentation/filesystems/sysfs.rst and show()
> should only use sysfs_emit() or sysfs_emit_at() when formatting the
> value to be returned to user space.
>
> Signed-off-by: ye xingchen <[email protected]>

Applied to for-next, thanks!


Attachments:
(No filename) (401.00 B)
signature.asc (849.00 B)
Download all attachments