2023-10-26 12:36:33

by Puliang Lu

Subject: [PATCH] USB: serial: option: modify Fibocom to DELL custom modem FM101R-GL

Modify the definition of Fibocom USB serial option driver
FM101R-GL different variants

- VID:PID 413C:8213, FM101R-GL ESIM are laptop M.2 cards (with
MBIM interfaces for Linux)

- VID:PID 413C:8215, FM101R-GL are laptop M.2 cards (with
MBIM interface for Linux)

0x8213: mbim, tty
0x8215: mbim, tty

Signed-off-by: Puliang Lu <[email protected]>
---
drivers/usb/serial/option.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/option.c
index 45dcfaadaf98..3aa219275509 100644
--- a/drivers/usb/serial/option.c
+++ b/drivers/usb/serial/option.c
@@ -203,8 +203,8 @@ static void option_instat_callback(struct urb *urb);
#define DELL_PRODUCT_5829E_ESIM 0x81e4
#define DELL_PRODUCT_5829E 0x81e6

-#define DELL_PRODUCT_FM101R 0x8213
-#define DELL_PRODUCT_FM101R_ESIM 0x8215
+#define DELL_PRODUCT_FM101R_ESIM 0x8213
+#define DELL_PRODUCT_FM101R 0x8215

#define KYOCERA_VENDOR_ID 0x0c88
#define KYOCERA_PRODUCT_KPC650 0x17da
--
2.34.1

2023-10-26 12:48:43

by Puliang Lu

Subject: Re: [PATCH] USB: serial: option: modify Fibocom to DELL custom modem FM101R-GL

> Modify the definition of Fibocom USB serial option driver FM101R-GL different variants
>
> - VID:PID 413C:8213, FM101R-GL ESIM are laptop M.2 cards (with
> MBIM interfaces for Linux)
>
> - VID:PID 413C:8215, FM101R-GL are laptop M.2 cards (with
> MBIM interface for Linux)
>
> 0x8213: mbim, tty
> 0x8215: mbim, tty
>
> Signed-off-by: Puliang Lu <[email protected]>
> ---
> drivers/usb/serial/option.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/option.c index 45dcfaadaf98..3aa219275509 100644
> --- a/drivers/usb/serial/option.c
> +++ b/drivers/usb/serial/option.c
> @@ -203,8 +203,8 @@ static void option_instat_callback(struct urb *urb);
> #define DELL_PRODUCT_5829E_ESIM 0x81e4
> #define DELL_PRODUCT_5829E 0x81e6
>
> -#define DELL_PRODUCT_FM101R 0x8213
> -#define DELL_PRODUCT_FM101R_ESIM 0x8215
> +#define DELL_PRODUCT_FM101R_ESIM 0x8213
> +#define DELL_PRODUCT_FM101R 0x8215
>
> #define KYOCERA_VENDOR_ID 0x0c88
> #define KYOCERA_PRODUCT_KPC650 0x17da
> --
> 2.34.1

Thank you for your feedback.
We apologize for any mistake and have now submitted the
incremental fix. Your input is greatly appreciated.

2023-11-15 07:06:28

by Johan Hovold

Subject: Re: [PATCH] USB: serial: option: modify Fibocom to DELL custom modem FM101R-GL

On Wed, Nov 15, 2023 at 04:11:02AM +0000, Puliang Lu(Puliang) wrote:
>
> > > Modify the definition of Fibocom USB serial option driver FM101R-GL different variants
> > >
> > > - VID:PID 413C:8213, FM101R-GL ESIM are laptop M.2 cards (with
> > > MBIM interfaces for Linux)
> > >
> > > - VID:PID 413C:8215, FM101R-GL are laptop M.2 cards (with
> > > MBIM interface for Linux)
> > >
> > > 0x8213: mbim, tty
> > > 0x8215: mbim, tty
> > >
> > > Signed-off-by: Puliang Lu <[email protected]>
> > > ---

> May I ask when this patch can be merged?

It's still in my queue and I haven't really looked at it yet. But don't
worry, it's not lost.

Johan

2023-11-21 13:26:18

by Johan Hovold

Subject: Re: [PATCH] USB: serial: option: modify Fibocom to DELL custom modem FM101R-GL

On Thu, Oct 26, 2023 at 08:35:06PM +0800, Puliang Lu wrote:
> Modify the definition of Fibocom USB serial option driver
> FM101R-GL different variants
>
> - VID:PID 413C:8213, FM101R-GL ESIM are laptop M.2 cards (with
> MBIM interfaces for Linux)
>
> - VID:PID 413C:8215, FM101R-GL are laptop M.2 cards (with
> MBIM interface for Linux)
>
> 0x8213: mbim, tty
> 0x8215: mbim, tty
>
> Signed-off-by: Puliang Lu <[email protected]>

> -#define DELL_PRODUCT_FM101R 0x8213
> -#define DELL_PRODUCT_FM101R_ESIM 0x8215
> +#define DELL_PRODUCT_FM101R_ESIM 0x8213
> +#define DELL_PRODUCT_FM101R 0x8215

You have an extra tab here so that the values are no longer aligned.

>
> #define KYOCERA_VENDOR_ID 0x0c88
> #define KYOCERA_PRODUCT_KPC650 0x17da

Now applied with a slightly updated commit message:

https://git.kernel.org/pub/scm/linux/kernel/git/johan/usb-serial.git/commit/?h=usb-linus&id=a1092619dd28ac0fcf23016160a2fdccd98ef935

Johan

2023-11-22 02:02:50

by Puliang Lu

Subject: Re: [PATCH] USB: serial: option: modify Fibocom to DELL custom modem FM101R-GL

> Now applied with a slightly updated commit message:
>
> https://git.kernel.org/pub/scm/linux/kernel/git/johan/usb-serial.git/commit/?h=usb-linus&id=a1092619dd28ac0fcf23016160a2fdccd98ef935

Thank you very much.