2024-02-13 08:29:19

by Krishna Kurapati PSSNV

[permalink] [raw]
Subject: [PATCH v2 0/2] Add DT support for Multiport controller on SC8280XP

Series [1] introduces binding and driver support for DWC3 Multiport
controllers. This series adds support for tertiary controller of SC8280
and enabled multiport controller for SA8295P-ADP platform.

Till v13 the DT was pushed along with driver code. Separate the DT changes
from driver update and pushing it as this series.

Changes in v2:
SA8540 Ride related code changes have been dropped and will pushed later
due to unavailability of hardware with either Andrew or me for testing the
gpio hog changes suggested in v1.
Implemented vbus boost regulators as fixed regulators instead of modelling
their enable pins as pinctrl nodes.

Link to v1:
https://lore.kernel.org/all/[email protected]/

[1]: https://lore.kernel.org/all/[email protected]/

Krishna Kurapati (2):
arm64: dts: qcom: sc8280xp: Add multiport controller node for SC8280
arm64: dts: qcom: sa8295p: Enable tertiary controller and its 4 USB
ports

arch/arm64/boot/dts/qcom/sa8295p-adp.dts | 83 ++++++++++++++++++++++++
arch/arm64/boot/dts/qcom/sc8280xp.dtsi | 82 +++++++++++++++++++++++
2 files changed, 165 insertions(+)

--
2.34.1



2024-02-13 08:46:59

by Johan Hovold

[permalink] [raw]
Subject: Re: [PATCH v2 0/2] Add DT support for Multiport controller on SC8280XP

On Tue, Feb 13, 2024 at 01:57:22PM +0530, Krishna Kurapati wrote:
> Series [1] introduces binding and driver support for DWC3 Multiport
> controllers. This series adds support for tertiary controller of SC8280
> and enabled multiport controller for SA8295P-ADP platform.
>
> Till v13 the DT was pushed along with driver code. Separate the DT changes
> from driver update and pushing it as this series.

Then this is version 15, don't reset the version number and hide all the
work that has gone into getting where we are today (e.g. by removing the
changelog).

> Changes in v2:
> SA8540 Ride related code changes have been dropped and will pushed later
> due to unavailability of hardware with either Andrew or me for testing the
> gpio hog changes suggested in v1.
> Implemented vbus boost regulators as fixed regulators instead of modelling
> their enable pins as pinctrl nodes.
>
> Link to v1:
> https://lore.kernel.org/all/[email protected]/
>
> [1]: https://lore.kernel.org/all/[email protected]/

Also make sure to include reviewers that have spend time on your series
as I'm sure I've asked you before.

Please fix in a v16.

Johan