2024-02-22 17:21:44

by Matthew Wilcox

Subject: Re: [PATCH] arm: flush: check if the folio is reserved for IMO addresses

On Thu, Feb 22, 2024 at 10:01:47PM +0800, Yongqiang Liu wrote:
> @@ -296,6 +297,9 @@ void __sync_icache_dcache(pte_t pteval)
> return;
>
> folio = page_folio(pfn_to_page(pfn));
> + if (test_bit(PG_reserved, &folio->flags))
> + return;

Why are you using PG_foo directly instead of the helpers?

if (folio_test_reserved(folio))

2024-02-23 01:57:47

by Yongqiang Liu

Subject: Re: [PATCH] arm: flush: check if the folio is reserved for IMO addresses

?? 2024/2/22 22:05, Matthew Wilcox д??:
> On Thu, Feb 22, 2024 at 10:01:47PM +0800, Yongqiang Liu wrote:
>> @@ -296,6 +297,9 @@ void __sync_icache_dcache(pte_t pteval)
>> return;
>>
>> folio = page_folio(pfn_to_page(pfn));
>> + if (test_bit(PG_reserved, &folio->flags))
>> + return;
> Why are you using PG_foo directly instead of the helpers?
>
> if (folio_test_reserved(folio))
> .
Sorry, I will send v2.