2023-01-18 16:34:32

by Jan Kiszka

[permalink] [raw]
Subject: [PATCH 2/3] dt-bindings: arm: ti: Add binding for Siemens IOT2050 M.2 variant

From: Jan Kiszka <[email protected]>

This new variant is derived from the Advanced PG2 board, replacing the
MiniPCI slot with B and E-keyed M.2 slots.

Signed-off-by: Jan Kiszka <[email protected]>
---
Documentation/devicetree/bindings/arm/ti/k3.yaml | 1 +
1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/arm/ti/k3.yaml b/Documentation/devicetree/bindings/arm/ti/k3.yaml
index 203faab80142..7af813202f1f 100644
--- a/Documentation/devicetree/bindings/arm/ti/k3.yaml
+++ b/Documentation/devicetree/bindings/arm/ti/k3.yaml
@@ -43,6 +43,7 @@ properties:
- enum:
- siemens,iot2050-advanced
- siemens,iot2050-advanced-pg2
+ - siemens,iot2050-advanced-m2
- siemens,iot2050-basic
- siemens,iot2050-basic-pg2
- ti,am654-evm
--
2.35.3


2023-01-18 17:28:01

by Krzysztof Kozlowski

[permalink] [raw]
Subject: Re: [PATCH 2/3] dt-bindings: arm: ti: Add binding for Siemens IOT2050 M.2 variant

On 18/01/2023 17:28, Jan Kiszka wrote:
> From: Jan Kiszka <[email protected]>
>
> This new variant is derived from the Advanced PG2 board, replacing the
> MiniPCI slot with B and E-keyed M.2 slots.
>
> Signed-off-by: Jan Kiszka <[email protected]>
> ---

Acked-by: Krzysztof Kozlowski <[email protected]>

Best regards,
Krzysztof

2023-01-18 18:03:11

by Vignesh Raghavendra

[permalink] [raw]
Subject: Re: [PATCH 2/3] dt-bindings: arm: ti: Add binding for Siemens IOT2050 M.2 variant

Hi Jan,

On 1/18/2023 9:58 PM, Jan Kiszka wrote:
> From: Jan Kiszka <[email protected]>
>
> This new variant is derived from the Advanced PG2 board, replacing the
> MiniPCI slot with B and E-keyed M.2 slots.
>
> Signed-off-by: Jan Kiszka <[email protected]>
> ---
> Documentation/devicetree/bindings/arm/ti/k3.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/arm/ti/k3.yaml b/Documentation/devicetree/bindings/arm/ti/k3.yaml
> index 203faab80142..7af813202f1f 100644
> --- a/Documentation/devicetree/bindings/arm/ti/k3.yaml
> +++ b/Documentation/devicetree/bindings/arm/ti/k3.yaml
> @@ -43,6 +43,7 @@ properties:
> - enum:
> - siemens,iot2050-advanced
> - siemens,iot2050-advanced-pg2
> + - siemens,iot2050-advanced-m2

Could you re arrange alphabetically?

> - siemens,iot2050-basic
> - siemens,iot2050-basic-pg2
> - ti,am654-evm


Regards
Vignesh

2023-01-19 06:49:51

by Jan Kiszka

[permalink] [raw]
Subject: Re: [PATCH 2/3] dt-bindings: arm: ti: Add binding for Siemens IOT2050 M.2 variant

On 18.01.23 18:43, Raghavendra, Vignesh wrote:
> Hi Jan,
>
> On 1/18/2023 9:58 PM, Jan Kiszka wrote:
>> From: Jan Kiszka <[email protected]>
>>
>> This new variant is derived from the Advanced PG2 board, replacing the
>> MiniPCI slot with B and E-keyed M.2 slots.
>>
>> Signed-off-by: Jan Kiszka <[email protected]>
>> ---
>> Documentation/devicetree/bindings/arm/ti/k3.yaml | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/Documentation/devicetree/bindings/arm/ti/k3.yaml b/Documentation/devicetree/bindings/arm/ti/k3.yaml
>> index 203faab80142..7af813202f1f 100644
>> --- a/Documentation/devicetree/bindings/arm/ti/k3.yaml
>> +++ b/Documentation/devicetree/bindings/arm/ti/k3.yaml
>> @@ -43,6 +43,7 @@ properties:
>> - enum:
>> - siemens,iot2050-advanced
>> - siemens,iot2050-advanced-pg2
>> + - siemens,iot2050-advanced-m2
>
> Could you re arrange alphabetically?

Time of release ordering, but I can reorder as well.

Jan

>
>> - siemens,iot2050-basic
>> - siemens,iot2050-basic-pg2
>> - ti,am654-evm
>
>
> Regards
> Vignesh

--
Siemens AG, Technology
Competence Center Embedded Linux

2023-01-19 08:23:44

by Krzysztof Kozlowski

[permalink] [raw]
Subject: Re: [PATCH 2/3] dt-bindings: arm: ti: Add binding for Siemens IOT2050 M.2 variant

On 19/01/2023 07:34, Jan Kiszka wrote:
> On 18.01.23 18:43, Raghavendra, Vignesh wrote:
>> Hi Jan,
>>
>> On 1/18/2023 9:58 PM, Jan Kiszka wrote:
>>> From: Jan Kiszka <[email protected]>
>>>
>>> This new variant is derived from the Advanced PG2 board, replacing the
>>> MiniPCI slot with B and E-keyed M.2 slots.
>>>
>>> Signed-off-by: Jan Kiszka <[email protected]>
>>> ---
>>> Documentation/devicetree/bindings/arm/ti/k3.yaml | 1 +
>>> 1 file changed, 1 insertion(+)
>>>
>>> diff --git a/Documentation/devicetree/bindings/arm/ti/k3.yaml b/Documentation/devicetree/bindings/arm/ti/k3.yaml
>>> index 203faab80142..7af813202f1f 100644
>>> --- a/Documentation/devicetree/bindings/arm/ti/k3.yaml
>>> +++ b/Documentation/devicetree/bindings/arm/ti/k3.yaml
>>> @@ -43,6 +43,7 @@ properties:
>>> - enum:
>>> - siemens,iot2050-advanced
>>> - siemens,iot2050-advanced-pg2
>>> + - siemens,iot2050-advanced-m2
>>
>> Could you re arrange alphabetically?
>
> Time of release ordering, but I can reorder as well.

The entries look ordered alphabetically, not by time of release. BTW, I
assume time of release != time of adding to Linux, which would be just
dropping stuff to the end...

Best regards,
Krzysztof