2023-01-20 08:45:38

by Krzysztof Kozlowski

[permalink] [raw]
Subject: [PATCH 2/2] dt-bindings: trivial-devices: document SPI dev compatibles

Document existing SPI dev compatibles.

Cc: Mark Brown <[email protected]>
Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
Documentation/devicetree/bindings/trivial-devices.yaml | 10 ++++++++++
1 file changed, 10 insertions(+)

diff --git a/Documentation/devicetree/bindings/trivial-devices.yaml b/Documentation/devicetree/bindings/trivial-devices.yaml
index b13f280f36fa..6d1dc1e2484a 100644
--- a/Documentation/devicetree/bindings/trivial-devices.yaml
+++ b/Documentation/devicetree/bindings/trivial-devices.yaml
@@ -65,6 +65,8 @@ properties:
- capella,cm3232
# CM3323: Ambient Light Sensor
- capella,cm3323
+ # Cisco SPI Petra
+ - cisco,spi-petra
# High-Precision Digital Thermometer
- dallas,ds1631
# Total-Elapsed-Time Recorder with Alarm
@@ -169,6 +171,8 @@ properties:
- isil,isl29030
# Intersil ISL68137 Digital Output Configurable PWM Controller
- isil,isl68137
+ # Linear Technology LTC2488
+ - lineartechnology,ltc2488
# 5 Bit Programmable, Pulse-Width Modulator
- maxim,ds1050
# 10 kOhm digital potentiometer with I2C interface
@@ -227,6 +231,8 @@ properties:
- memsic,mxc6655
# Menlo on-board CPLD trivial SPI device
- menlo,m53cpld
+ # Micron SPI NOR Authenta
+ - micron,spi-authenta
# Microchip differential I2C ADC, 1 Channel, 18 bit
- microchip,mcp3421
# Microchip differential I2C ADC, 2 Channel, 18 bit
@@ -305,10 +311,14 @@ properties:
- pulsedlight,lidar-lite-v2
# Renesas ISL29501 time-of-flight sensor
- renesas,isl29501
+ # Rohm DH2228FV
+ - rohm,dh2228fv
# S524AD0XF1 (128K/256K-bit Serial EEPROM for Low Power)
- samsung,24ad0xd1
# Samsung Exynos SoC SATA PHY I2C device
- samsung,exynos-sataphy-i2c
+ # Semtech sx1301 baseband processor
+ - semtech,sx1301
# Sensirion low power multi-pixel gas sensor with I2C interface
- sensirion,sgpc3
# Sensirion multi-pixel gas sensor with I2C interface
--
2.34.1


2023-01-20 15:37:33

by Mark Brown

[permalink] [raw]
Subject: Re: [PATCH 2/2] dt-bindings: trivial-devices: document SPI dev compatibles

On Fri, Jan 20, 2023 at 08:56:18AM +0100, Krzysztof Kozlowski wrote:
> Document existing SPI dev compatibles.

I'm missing patch 1/2 here - what's the story with dependencies?


Attachments:
(No filename) (180.00 B)
signature.asc (499.00 B)
Download all attachments

2023-01-21 20:54:19

by Krzysztof Kozlowski

[permalink] [raw]
Subject: Re: [PATCH 2/2] dt-bindings: trivial-devices: document SPI dev compatibles

On 20/01/2023 16:09, Mark Brown wrote:
> On Fri, Jan 20, 2023 at 08:56:18AM +0100, Krzysztof Kozlowski wrote:
>> Document existing SPI dev compatibles.
>
> I'm missing patch 1/2 here - what's the story with dependencies?

Sorry for that, I should Cc everyone. First patch [1] is just vendor
prefix, which should rather go via Rob's DT tree to avoid any conflicts.
There is no dependency, so if Rob is fine with this, please take the
patch here.

[1]
https://lore.kernel.org/all/[email protected]/

Best regards,
Krzysztof

2023-01-23 22:03:09

by Rob Herring

[permalink] [raw]
Subject: Re: [PATCH 2/2] dt-bindings: trivial-devices: document SPI dev compatibles

On Fri, Jan 20, 2023 at 08:56:18AM +0100, Krzysztof Kozlowski wrote:
> Document existing SPI dev compatibles.
>
> Cc: Mark Brown <[email protected]>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
> ---
> Documentation/devicetree/bindings/trivial-devices.yaml | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/trivial-devices.yaml b/Documentation/devicetree/bindings/trivial-devices.yaml
> index b13f280f36fa..6d1dc1e2484a 100644
> --- a/Documentation/devicetree/bindings/trivial-devices.yaml
> +++ b/Documentation/devicetree/bindings/trivial-devices.yaml
> @@ -65,6 +65,8 @@ properties:
> - capella,cm3232
> # CM3323: Ambient Light Sensor
> - capella,cm3323
> + # Cisco SPI Petra
> + - cisco,spi-petra
> # High-Precision Digital Thermometer
> - dallas,ds1631
> # Total-Elapsed-Time Recorder with Alarm
> @@ -169,6 +171,8 @@ properties:
> - isil,isl29030
> # Intersil ISL68137 Digital Output Configurable PWM Controller
> - isil,isl68137
> + # Linear Technology LTC2488
> + - lineartechnology,ltc2488
> # 5 Bit Programmable, Pulse-Width Modulator
> - maxim,ds1050
> # 10 kOhm digital potentiometer with I2C interface
> @@ -227,6 +231,8 @@ properties:
> - memsic,mxc6655
> # Menlo on-board CPLD trivial SPI device
> - menlo,m53cpld
> + # Micron SPI NOR Authenta
> + - micron,spi-authenta

Not a simple device and something we don't want to endorse:

https://lore.kernel.org/all/CAL_Jsq+2xGdPnrCnQwf12k37DeZxekS6-wp6qrp3iDa7WLWsCw@mail.gmail.com/

Rob

2023-01-24 07:31:43

by Krzysztof Kozlowski

[permalink] [raw]
Subject: Re: [PATCH 2/2] dt-bindings: trivial-devices: document SPI dev compatibles

On 23/01/2023 23:02, Rob Herring wrote:
> On Fri, Jan 20, 2023 at 08:56:18AM +0100, Krzysztof Kozlowski wrote:
>> Document existing SPI dev compatibles.
>>
>> Cc: Mark Brown <[email protected]>
>> Signed-off-by: Krzysztof Kozlowski <[email protected]>
>> ---
>> Documentation/devicetree/bindings/trivial-devices.yaml | 10 ++++++++++
>> 1 file changed, 10 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/trivial-devices.yaml b/Documentation/devicetree/bindings/trivial-devices.yaml
>> index b13f280f36fa..6d1dc1e2484a 100644
>> --- a/Documentation/devicetree/bindings/trivial-devices.yaml
>> +++ b/Documentation/devicetree/bindings/trivial-devices.yaml
>> @@ -65,6 +65,8 @@ properties:
>> - capella,cm3232
>> # CM3323: Ambient Light Sensor
>> - capella,cm3323
>> + # Cisco SPI Petra
>> + - cisco,spi-petra
>> # High-Precision Digital Thermometer
>> - dallas,ds1631
>> # Total-Elapsed-Time Recorder with Alarm
>> @@ -169,6 +171,8 @@ properties:
>> - isil,isl29030
>> # Intersil ISL68137 Digital Output Configurable PWM Controller
>> - isil,isl68137
>> + # Linear Technology LTC2488
>> + - lineartechnology,ltc2488
>> # 5 Bit Programmable, Pulse-Width Modulator
>> - maxim,ds1050
>> # 10 kOhm digital potentiometer with I2C interface
>> @@ -227,6 +231,8 @@ properties:
>> - memsic,mxc6655
>> # Menlo on-board CPLD trivial SPI device
>> - menlo,m53cpld
>> + # Micron SPI NOR Authenta
>> + - micron,spi-authenta
>
> Not a simple device and something we don't want to endorse:
>
> https://lore.kernel.org/all/CAL_Jsq+2xGdPnrCnQwf12k37DeZxekS6-wp6qrp3iDa7WLWsCw@mail.gmail.com/

It already made its way to SPI dev driver, but sure, I can drop it.

Best regards,
Krzysztof