2021-05-27 08:57:30

by Baokun Li

Subject: [PATCH -next] coda: Remove set but not used variable 'err'

Fixes gcc '-Wunused-but-set-variable' warning:

fs/coda/file.c: In function 'coda_release':
fs/coda/file.c:241:6: warning:
variable ‘err’ set but not used [-Wunused-but-set-variable]

It never used since introduction.

Signed-off-by: Baokun Li <[email protected]>
---
fs/coda/file.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/fs/coda/file.c b/fs/coda/file.c
index ef5ca22bfb3e..98eb543d4acc 100644
--- a/fs/coda/file.c
+++ b/fs/coda/file.c
@@ -238,12 +238,11 @@ int coda_release(struct inode *coda_inode, struct file *coda_file)
struct coda_file_info *cfi;
struct coda_inode_info *cii;
struct inode *host_inode;
- int err;

cfi = coda_ftoc(coda_file);

- err = venus_close(coda_inode->i_sb, coda_i2f(coda_inode),
- coda_flags, coda_file->f_cred->fsuid);
+ venus_close(coda_inode->i_sb, coda_i2f(coda_inode),
+ coda_flags, coda_file->f_cred->fsuid);

host_inode = file_inode(cfi->cfi_container);
cii = ITOC(coda_inode);
--
2.25.4

2021-06-15 02:36:10

by Baokun Li

Subject: Re: [PATCH -next] coda: Remove set but not used variable 'err'

ping

在 2021/5/27 17:05, Baokun Li 写道:
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> fs/coda/file.c: In function 'coda_release':
> fs/coda/file.c:241:6: warning:
> variable ‘err’ set but not used [-Wunused-but-set-variable]
>
> It never used since introduction.
>
> Signed-off-by: Baokun Li <[email protected]>
> ---
> fs/coda/file.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/fs/coda/file.c b/fs/coda/file.c
> index ef5ca22bfb3e..98eb543d4acc 100644
> --- a/fs/coda/file.c
> +++ b/fs/coda/file.c
> @@ -238,12 +238,11 @@ int coda_release(struct inode *coda_inode, struct file *coda_file)
> struct coda_file_info *cfi;
> struct coda_inode_info *cii;
> struct inode *host_inode;
> - int err;
>
> cfi = coda_ftoc(coda_file);
>
> - err = venus_close(coda_inode->i_sb, coda_i2f(coda_inode),
> - coda_flags, coda_file->f_cred->fsuid);
> + venus_close(coda_inode->i_sb, coda_i2f(coda_inode),
> + coda_flags, coda_file->f_cred->fsuid);
>
> host_inode = file_inode(cfi->cfi_container);
> cii = ITOC(coda_inode);