2020-11-18 14:35:02

by Grygorii Strashko

Subject: [PATCH] gpio: omap: handle deferred probe with dev_err_probe() for gpiochip_add_data()

The gpiochip_add_data() may return -EPROBE_DEFER which is not handled
properly by TI GPIO driver and causes unnecessary boot log messages.

Hence, add proper deferred probe handling with new dev_err_probe() API.

Signed-off-by: Grygorii Strashko <[email protected]>
---
drivers/gpio/gpio-omap.c | 7 ++-----
1 file changed, 2 insertions(+), 5 deletions(-)

diff --git a/drivers/gpio/gpio-omap.c b/drivers/gpio/gpio-omap.c
index f7ceb2b11afc..41952bb818ad 100644
--- a/drivers/gpio/gpio-omap.c
+++ b/drivers/gpio/gpio-omap.c
@@ -1049,11 +1049,8 @@ static int omap_gpio_chip_init(struct gpio_bank *bank, struct irq_chip *irqc)
irq->first = irq_base;

ret = gpiochip_add_data(&bank->chip, bank);
- if (ret) {
- dev_err(bank->chip.parent,
- "Could not register gpio chip %d\n", ret);
- return ret;
- }
+ if (ret)
+ return dev_err_probe(bank->chip.parent, ret, "Could not register gpio chip\n");

ret = devm_request_irq(bank->chip.parent, bank->irq,
omap_gpio_irq_handler,
--
2.17.1

2020-11-19 09:22:47

by Tony Lindgren

Subject: Re: [PATCH] gpio: omap: handle deferred probe with dev_err_probe() for gpiochip_add_data()

* Grygorii Strashko <[email protected]> [201118 14:33]:
> The gpiochip_add_data() may return -EPROBE_DEFER which is not handled
> properly by TI GPIO driver and causes unnecessary boot log messages.
>
> Hence, add proper deferred probe handling with new dev_err_probe() API.
>
> Signed-off-by: Grygorii Strashko <[email protected]>

Acked-by: Tony Lindgren <[email protected]>

2020-11-30 10:36:52

by Grygorii Strashko

Subject: Re: [PATCH] gpio: omap: handle deferred probe with dev_err_probe() for gpiochip_add_data()

Hi All,

On 19/11/2020 11:19, Tony Lindgren wrote:
> * Grygorii Strashko <[email protected]> [201118 14:33]:
>> The gpiochip_add_data() may return -EPROBE_DEFER which is not handled
>> properly by TI GPIO driver and causes unnecessary boot log messages.
>>
>> Hence, add proper deferred probe handling with new dev_err_probe() API.
>>
>> Signed-off-by: Grygorii Strashko <[email protected]>
>
> Acked-by: Tony Lindgren <[email protected]>
>

Are there any comments? Could it be merged?
On am335 we no do see ~10 annoying error messages during boot as there now is
dependency from pinctrl on this platform.

--
Best regards,
grygorii

2020-11-30 16:44:02

by Bartosz Golaszewski

Subject: Re: [PATCH] gpio: omap: handle deferred probe with dev_err_probe() for gpiochip_add_data()

On Wed, Nov 18, 2020 at 3:31 PM Grygorii Strashko
<[email protected]> wrote:
>
> The gpiochip_add_data() may return -EPROBE_DEFER which is not handled
> properly by TI GPIO driver and causes unnecessary boot log messages.
>
> Hence, add proper deferred probe handling with new dev_err_probe() API.
>
> Signed-off-by: Grygorii Strashko <[email protected]>
> ---
> drivers/gpio/gpio-omap.c | 7 ++-----
> 1 file changed, 2 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/gpio/gpio-omap.c b/drivers/gpio/gpio-omap.c
> index f7ceb2b11afc..41952bb818ad 100644
> --- a/drivers/gpio/gpio-omap.c
> +++ b/drivers/gpio/gpio-omap.c
> @@ -1049,11 +1049,8 @@ static int omap_gpio_chip_init(struct gpio_bank *bank, struct irq_chip *irqc)
> irq->first = irq_base;
>
> ret = gpiochip_add_data(&bank->chip, bank);
> - if (ret) {
> - dev_err(bank->chip.parent,
> - "Could not register gpio chip %d\n", ret);
> - return ret;
> - }
> + if (ret)
> + return dev_err_probe(bank->chip.parent, ret, "Could not register gpio chip\n");
>
> ret = devm_request_irq(bank->chip.parent, bank->irq,
> omap_gpio_irq_handler,
> --
> 2.17.1
>

Now applied. Thanks!

Bartosz