2019-01-18 13:34:51

by Stefan Agner

[permalink] [raw]
Subject: [PATCH] ARM: dts: imx6qdl-apalis: add phy-supply

Use the VDD I/O rail as phy-supply regulator. Technically, the
regulator has multiple rails, but currently the driver only
supports a single phy-supply. The VDD I/O rail has the highest
power consumption when software power down is used and hence
the highest saving potential.

Signed-off-by: Stefan Agner <[email protected]>
---
arch/arm/boot/dts/imx6qdl-apalis.dtsi | 1 +
1 file changed, 1 insertion(+)

diff --git a/arch/arm/boot/dts/imx6qdl-apalis.dtsi b/arch/arm/boot/dts/imx6qdl-apalis.dtsi
index 0b47aecf336a..cf66f9ececbd 100644
--- a/arch/arm/boot/dts/imx6qdl-apalis.dtsi
+++ b/arch/arm/boot/dts/imx6qdl-apalis.dtsi
@@ -241,6 +241,7 @@
phy-handle = <&ethphy>;
phy-reset-duration = <10>;
phy-reset-gpios = <&gpio1 25 GPIO_ACTIVE_LOW>;
+ phy-supply = <&vgen5_reg>;
status = "okay";

mdio {
--
2.20.1



2019-01-21 08:37:15

by Philippe Schenker

[permalink] [raw]
Subject: Re: [PATCH] ARM: dts: imx6qdl-apalis: add phy-supply

On Fri, 2019-01-18 at 14:32 +0100, Stefan Agner wrote:
> Use the VDD I/O rail as phy-supply regulator. Technically, the
> regulator has multiple rails, but currently the driver only
> supports a single phy-supply. The VDD I/O rail has the highest
> power consumption when software power down is used and hence
> the highest saving potential.
>
> Signed-off-by: Stefan Agner <[email protected]>

Reviewed-by: Philippe Schenker <[email protected]>

> ---
> arch/arm/boot/dts/imx6qdl-apalis.dtsi | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/boot/dts/imx6qdl-apalis.dtsi
> b/arch/arm/boot/dts/imx6qdl-apalis.dtsi
> index 0b47aecf336a..cf66f9ececbd 100644
> --- a/arch/arm/boot/dts/imx6qdl-apalis.dtsi
> +++ b/arch/arm/boot/dts/imx6qdl-apalis.dtsi
> @@ -241,6 +241,7 @@
> phy-handle = <&ethphy>;
> phy-reset-duration = <10>;
> phy-reset-gpios = <&gpio1 25 GPIO_ACTIVE_LOW>;
> + phy-supply = <&vgen5_reg>;
> status = "okay";
>
> mdio {


2019-01-21 14:31:53

by Stefan Agner

[permalink] [raw]
Subject: Re: [PATCH] ARM: dts: imx6qdl-apalis: add phy-supply

On 18.01.2019 14:32, Stefan Agner wrote:
> Use the VDD I/O rail as phy-supply regulator. Technically, the
> regulator has multiple rails, but currently the driver only
> supports a single phy-supply. The VDD I/O rail has the highest
> power consumption when software power down is used and hence
> the highest saving potential.

Please don't merge this patch. The vgen5_reg is also used as a pull-up
for USB ID pin, it would not be safe for the FEC driver to disable this
rail.

--
Stefan


>
> Signed-off-by: Stefan Agner <[email protected]>
> ---
> arch/arm/boot/dts/imx6qdl-apalis.dtsi | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/boot/dts/imx6qdl-apalis.dtsi
> b/arch/arm/boot/dts/imx6qdl-apalis.dtsi
> index 0b47aecf336a..cf66f9ececbd 100644
> --- a/arch/arm/boot/dts/imx6qdl-apalis.dtsi
> +++ b/arch/arm/boot/dts/imx6qdl-apalis.dtsi
> @@ -241,6 +241,7 @@
> phy-handle = <&ethphy>;
> phy-reset-duration = <10>;
> phy-reset-gpios = <&gpio1 25 GPIO_ACTIVE_LOW>;
> + phy-supply = <&vgen5_reg>;
> status = "okay";
>
> mdio {