2020-07-09 03:29:49

by Stephen Rothwell

[permalink] [raw]

Subject: linux-next: build warning after merge of the device-mapper tree

---

Hi all,

After merging the device-mapper tree, today's linux-next build (x86_64
allmodconfig) produced this warning:

In file included from drivers/md/dm-dust.c:11:
drivers/md/dm-dust.c: In function 'dust_list_badblocks':
drivers/md/dm-dust.c:307:10: warning: zero-length gnu_printf format string [-Wformat-zero-length]
307 | DMEMIT("");
| ^~
include/linux/device-mapper.h:555:46: note: in definition of macro 'DMEMIT'
555 | 0 : scnprintf(result + sz, maxlen - sz, x))
| ^

Introduced by commit

20f93ea74f9c ("dm dust: add interface to list all badblocks")

--
Cheers,
Stephen Rothwell

---

Attachments:

(No filename) (499.00 B)
OpenPGP digital signature

2020-07-09 04:40:58

by yangerkun

[permalink] [raw]

Subject: Re: linux-next: build warning after merge of the device-mapper tree

---

在 2020/7/9 11:26, Stephen Rothwell 写道:
> Hi all,
>
> After merging the device-mapper tree, today's linux-next build (x86_64
> allmodconfig) produced this warning:
>
> In file included from drivers/md/dm-dust.c:11:
> drivers/md/dm-dust.c: In function 'dust_list_badblocks':
> drivers/md/dm-dust.c:307:10: warning: zero-length gnu_printf format string [-Wformat-zero-length]
> 307 | DMEMIT("");
Mike and Bryan,

Should we just use "DMEMIT("\n")"? Maybe it's bad since this lead a
blank line...


> | ^~
> include/linux/device-mapper.h:555:46: note: in definition of macro 'DMEMIT'
> 555 | 0 : scnprintf(result + sz, maxlen - sz, x))
> | ^
>
> Introduced by commit
>
> 20f93ea74f9c ("dm dust: add interface to list all badblocks")
>