2017-09-21 06:03:44

by Baolin Wang

Subject: [PATCH] sound: core: Fix structure definition for X32 ABI

X32 ABI uses the 64bit timespec in addition to 64bit alignment of 64bit
values. We have added compat ABI for these ioctls, but this patch adds
one missing padding into 'struct snd_pcm_mmap_status_x32' to fix
incompatibilities.

Signed-off-by: Baolin Wang <[email protected]>
---
sound/core/pcm_compat.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/sound/core/pcm_compat.c b/sound/core/pcm_compat.c
index 10f537f..29ab480 100644
--- a/sound/core/pcm_compat.c
+++ b/sound/core/pcm_compat.c
@@ -547,6 +547,7 @@ struct snd_pcm_mmap_status_x32 {
u32 pad2; /* alignment */
struct timespec tstamp;
s32 suspended_state;
+ s32 pad3;
struct timespec audio_tstamp;
} __packed;

--
1.7.9.5

2017-09-22 09:25:21

by Takashi Iwai

Subject: Re: [PATCH] sound: core: Fix structure definition for X32 ABI

On Thu, 21 Sep 2017 08:03:29 +0200,
Baolin Wang wrote:
>
> X32 ABI uses the 64bit timespec in addition to 64bit alignment of 64bit
> values. We have added compat ABI for these ioctls, but this patch adds
> one missing padding into 'struct snd_pcm_mmap_status_x32' to fix
> incompatibilities.
>
> Signed-off-by: Baolin Wang <[email protected]>

Applied, thanks.


Takashi