On 22/12/2022 11:39, Bhavya Kapoor wrote:
>
> On 21/12/22 13:24, Krzysztof Kozlowski wrote:
>> On 21/12/2022 06:42, Bhavya Kapoor wrote:
>>> On 20/12/22 16:20, Krzysztof Kozlowski wrote:
>>>> On 20/12/2022 11:12, Bhavya Kapoor wrote:
>>>>> J721s2 has two instances of 8 channel ADCs in MCU domain. Add DT nodes
>>>>> for 8 channel ADCs for J721s2 SoC.
>>>>>
>>>>> Signed-off-by: Bhavya Kapoor <[email protected]>
>>>>> ---
>>>>> .../dts/ti/k3-j721s2-common-proc-board.dts | 14 +++++++
>>>>> .../boot/dts/ti/k3-j721s2-mcu-wakeup.dtsi | 42 ++++++++++++++++++-
>>>>> 2 files changed, 55 insertions(+), 1 deletion(-)
>>>>>
>>>>> diff --git a/arch/arm64/boot/dts/ti/k3-j721s2-common-proc-board.dts b/arch/arm64/boot/dts/ti/k3-j721s2-common-proc-board.dts
>>>>> index a7aa6cf08acd..67593aa69327 100644
>>>>> --- a/arch/arm64/boot/dts/ti/k3-j721s2-common-proc-board.dts
>>>>> +++ b/arch/arm64/boot/dts/ti/k3-j721s2-common-proc-board.dts
>>>>> @@ -309,3 +309,17 @@ &mcu_mcan1 {
>>>>> pinctrl-0 = <&mcu_mcan1_pins_default>;
>>>>> phys = <&transceiver2>;
>>>>> };
>>>>> +
>>>>> +&tscadc0 {
>>>>> + status = "okay";
>>>>> + adc {
>>>>> + ti,adc-channels = <0 1 2 3 4 5 6 7>;
>>>>> + };
>>>>> +};
>>>>> +
>>>>> +&tscadc1 {
>>>>> + status = "okay";
>>>>> + adc {
>>>>> + ti,adc-channels = <0 1 2 3 4 5 6 7>;
>>>>> + };
>>>>> +};
>>>>> \ No newline at end of file
>>>> This is a friendly reminder during the review process.
>>>>
>>>> It seems my previous comments were not fully addressed. Maybe my
>>>> feedback got lost between the quotes, maybe you just forgot to apply it.
>>>> Please go back to the previous discussion and either implement all
>>>> requested changes or keep discussing them.
>>>>
>>>> Thank you.
>>>>
>>>> Best regards,
>>>> Krzysztof
>>> Hi , I thought i did addressed the feedback since tscadc is just a
>>> wrapper node.
>>>
>>> The actual adc node is inside of tscadc node.
>> Read the feedback, from all emails.
>> Best regards,
>> Krzysztof
>
>
> Hi , i have gone through all earlier mails but can't find anything else.
> Can you point out again whats the issue.
"And this is a v2? Or resend? Or something else?"
You miss proper versioning and changelog.
Additionally - I commented just before error in your patch. You must fix
it, not ignore it, even though I did not point it out before.
Best regards,
Krzysztof
On 22/12/22 16:16, Krzysztof Kozlowski wrote:
> On 22/12/2022 11:39, Bhavya Kapoor wrote:
>> On 21/12/22 13:24, Krzysztof Kozlowski wrote:
>>> On 21/12/2022 06:42, Bhavya Kapoor wrote:
>>>> On 20/12/22 16:20, Krzysztof Kozlowski wrote:
>>>>> On 20/12/2022 11:12, Bhavya Kapoor wrote:
>>>>>> J721s2 has two instances of 8 channel ADCs in MCU domain. Add DT nodes
>>>>>> for 8 channel ADCs for J721s2 SoC.
>>>>>>
>>>>>> Signed-off-by: Bhavya Kapoor <[email protected]>
>>>>>> ---
>>>>>> .../dts/ti/k3-j721s2-common-proc-board.dts | 14 +++++++
>>>>>> .../boot/dts/ti/k3-j721s2-mcu-wakeup.dtsi | 42 ++++++++++++++++++-
>>>>>> 2 files changed, 55 insertions(+), 1 deletion(-)
>>>>>>
>>>>>> diff --git a/arch/arm64/boot/dts/ti/k3-j721s2-common-proc-board.dts b/arch/arm64/boot/dts/ti/k3-j721s2-common-proc-board.dts
>>>>>> index a7aa6cf08acd..67593aa69327 100644
>>>>>> --- a/arch/arm64/boot/dts/ti/k3-j721s2-common-proc-board.dts
>>>>>> +++ b/arch/arm64/boot/dts/ti/k3-j721s2-common-proc-board.dts
>>>>>> @@ -309,3 +309,17 @@ &mcu_mcan1 {
>>>>>> pinctrl-0 = <&mcu_mcan1_pins_default>;
>>>>>> phys = <&transceiver2>;
>>>>>> };
>>>>>> +
>>>>>> +&tscadc0 {
>>>>>> + status = "okay";
>>>>>> + adc {
>>>>>> + ti,adc-channels = <0 1 2 3 4 5 6 7>;
>>>>>> + };
>>>>>> +};
>>>>>> +
>>>>>> +&tscadc1 {
>>>>>> + status = "okay";
>>>>>> + adc {
>>>>>> + ti,adc-channels = <0 1 2 3 4 5 6 7>;
>>>>>> + };
>>>>>> +};
>>>>>> \ No newline at end of file
>>>>> This is a friendly reminder during the review process.
>>>>>
>>>>> It seems my previous comments were not fully addressed. Maybe my
>>>>> feedback got lost between the quotes, maybe you just forgot to apply it.
>>>>> Please go back to the previous discussion and either implement all
>>>>> requested changes or keep discussing them.
>>>>>
>>>>> Thank you.
>>>>>
>>>>> Best regards,
>>>>> Krzysztof
>>>> Hi , I thought i did addressed the feedback since tscadc is just a
>>>> wrapper node.
>>>>
>>>> The actual adc node is inside of tscadc node.
>>> Read the feedback, from all emails.
>>> Best regards,
>>> Krzysztof
>>
>> Hi , i have gone through all earlier mails but can't find anything else.
>> Can you point out again whats the issue.
> "And this is a v2? Or resend? Or something else?"
>
> You miss proper versioning and changelog.
>
> Additionally - I commented just before error in your patch. You must fix
> it, not ignore it, even though I did not point it out before.
>
> Best regards,
> Krzysztof
Hi, i had replied to that as well earlier. You can check that out
https://lore.kernel.org/all/[email protected]/ .
Maybe you missed out on that.
Regards
On 22/12/2022 12:53, Bhavya Kapoor wrote:
>
> On 22/12/22 16:16, Krzysztof Kozlowski wrote:
>> On 22/12/2022 11:39, Bhavya Kapoor wrote:
>>> On 21/12/22 13:24, Krzysztof Kozlowski wrote:
>>>> On 21/12/2022 06:42, Bhavya Kapoor wrote:
>>>>> On 20/12/22 16:20, Krzysztof Kozlowski wrote:
>>>>>> On 20/12/2022 11:12, Bhavya Kapoor wrote:
>>>>>>> J721s2 has two instances of 8 channel ADCs in MCU domain. Add DT nodes
>>>>>>> for 8 channel ADCs for J721s2 SoC.
>>>>>>>
>>>>>>> Signed-off-by: Bhavya Kapoor <[email protected]>
>>>>>>> ---
>>>>>>> .../dts/ti/k3-j721s2-common-proc-board.dts | 14 +++++++
>>>>>>> .../boot/dts/ti/k3-j721s2-mcu-wakeup.dtsi | 42 ++++++++++++++++++-
>>>>>>> 2 files changed, 55 insertions(+), 1 deletion(-)
>>>>>>>
>>>>>>> diff --git a/arch/arm64/boot/dts/ti/k3-j721s2-common-proc-board.dts b/arch/arm64/boot/dts/ti/k3-j721s2-common-proc-board.dts
>>>>>>> index a7aa6cf08acd..67593aa69327 100644
>>>>>>> --- a/arch/arm64/boot/dts/ti/k3-j721s2-common-proc-board.dts
>>>>>>> +++ b/arch/arm64/boot/dts/ti/k3-j721s2-common-proc-board.dts
>>>>>>> @@ -309,3 +309,17 @@ &mcu_mcan1 {
>>>>>>> pinctrl-0 = <&mcu_mcan1_pins_default>;
>>>>>>> phys = <&transceiver2>;
>>>>>>> };
>>>>>>> +
>>>>>>> +&tscadc0 {
>>>>>>> + status = "okay";
>>>>>>> + adc {
>>>>>>> + ti,adc-channels = <0 1 2 3 4 5 6 7>;
>>>>>>> + };
>>>>>>> +};
>>>>>>> +
>>>>>>> +&tscadc1 {
>>>>>>> + status = "okay";
>>>>>>> + adc {
>>>>>>> + ti,adc-channels = <0 1 2 3 4 5 6 7>;
>>>>>>> + };
>>>>>>> +};
>>>>>>> \ No newline at end of file
>>>>>> This is a friendly reminder during the review process.
>>>>>>
>>>>>> It seems my previous comments were not fully addressed. Maybe my
>>>>>> feedback got lost between the quotes, maybe you just forgot to apply it.
>>>>>> Please go back to the previous discussion and either implement all
>>>>>> requested changes or keep discussing them.
>>>>>>
>>>>>> Thank you.
>>>>>>
>>>>>> Best regards,
>>>>>> Krzysztof
>>>>> Hi , I thought i did addressed the feedback since tscadc is just a
>>>>> wrapper node.
>>>>>
>>>>> The actual adc node is inside of tscadc node.
>>>> Read the feedback, from all emails.
>>>> Best regards,
>>>> Krzysztof
>>>
>>> Hi , i have gone through all earlier mails but can't find anything else.
>>> Can you point out again whats the issue.
>> "And this is a v2? Or resend? Or something else?"
>>
>> You miss proper versioning and changelog.
>>
>> Additionally - I commented just before error in your patch. You must fix
>> it, not ignore it, even though I did not point it out before.
>>
>> Best regards,
>> Krzysztof
>
> Hi, i had replied to that as well earlier. You can check that out
> https://lore.kernel.org/all/[email protected]/ .
BTW, there is nothing there about the patch error I wrote here. If not,
please point me to the quote which addresses this patch error.
Best regards,
Krzysztof
On 22/12/2022 12:53, Bhavya Kapoor wrote:
>
> On 22/12/22 16:16, Krzysztof Kozlowski wrote:
>> On 22/12/2022 11:39, Bhavya Kapoor wrote:
>>> On 21/12/22 13:24, Krzysztof Kozlowski wrote:
>>>> On 21/12/2022 06:42, Bhavya Kapoor wrote:
>>>>> On 20/12/22 16:20, Krzysztof Kozlowski wrote:
>>>>>> On 20/12/2022 11:12, Bhavya Kapoor wrote:
>>>>>>> J721s2 has two instances of 8 channel ADCs in MCU domain. Add DT nodes
>>>>>>> for 8 channel ADCs for J721s2 SoC.
>>>>>>>
>>>>>>> Signed-off-by: Bhavya Kapoor <[email protected]>
>>>>>>> ---
>>>>>>> .../dts/ti/k3-j721s2-common-proc-board.dts | 14 +++++++
>>>>>>> .../boot/dts/ti/k3-j721s2-mcu-wakeup.dtsi | 42 ++++++++++++++++++-
>>>>>>> 2 files changed, 55 insertions(+), 1 deletion(-)
>>>>>>>
>>>>>>> diff --git a/arch/arm64/boot/dts/ti/k3-j721s2-common-proc-board.dts b/arch/arm64/boot/dts/ti/k3-j721s2-common-proc-board.dts
>>>>>>> index a7aa6cf08acd..67593aa69327 100644
>>>>>>> --- a/arch/arm64/boot/dts/ti/k3-j721s2-common-proc-board.dts
>>>>>>> +++ b/arch/arm64/boot/dts/ti/k3-j721s2-common-proc-board.dts
>>>>>>> @@ -309,3 +309,17 @@ &mcu_mcan1 {
>>>>>>> pinctrl-0 = <&mcu_mcan1_pins_default>;
>>>>>>> phys = <&transceiver2>;
>>>>>>> };
>>>>>>> +
>>>>>>> +&tscadc0 {
>>>>>>> + status = "okay";
>>>>>>> + adc {
>>>>>>> + ti,adc-channels = <0 1 2 3 4 5 6 7>;
>>>>>>> + };
>>>>>>> +};
>>>>>>> +
>>>>>>> +&tscadc1 {
>>>>>>> + status = "okay";
>>>>>>> + adc {
>>>>>>> + ti,adc-channels = <0 1 2 3 4 5 6 7>;
>>>>>>> + };
>>>>>>> +};
>>>>>>> \ No newline at end of file
>>>>>> This is a friendly reminder during the review process.
>>>>>>
>>>>>> It seems my previous comments were not fully addressed. Maybe my
>>>>>> feedback got lost between the quotes, maybe you just forgot to apply it.
>>>>>> Please go back to the previous discussion and either implement all
>>>>>> requested changes or keep discussing them.
>>>>>>
>>>>>> Thank you.
>>>>>>
>>>>>> Best regards,
>>>>>> Krzysztof
>>>>> Hi , I thought i did addressed the feedback since tscadc is just a
>>>>> wrapper node.
>>>>>
>>>>> The actual adc node is inside of tscadc node.
>>>> Read the feedback, from all emails.
>>>> Best regards,
>>>> Krzysztof
>>>
>>> Hi , i have gone through all earlier mails but can't find anything else.
>>> Can you point out again whats the issue.
>> "And this is a v2? Or resend? Or something else?"
>>
>> You miss proper versioning and changelog.
>>
>> Additionally - I commented just before error in your patch. You must fix
>> it, not ignore it, even though I did not point it out before.
>>
>> Best regards,
>> Krzysztof
>
> Hi, i had replied to that as well earlier. You can check that out
> https://lore.kernel.org/all/[email protected]/ .
>
> Maybe you missed out on that.
So this is a duplicate? OK, then this patch can be:
NAK
Best regards,
Krzysztof