2019-12-13 03:42:09

by Rocky Liao

[permalink] [raw]
Subject: Re: [PATCH v1 2/2] dt-bindings: net: bluetooth: Add device tree bindings for QCA6390

在 2019-12-12 18:33，Marcel Holtmann 写道：
> Hi Rocky,
>
>> Add compatible string for the Qualcomm QCA6390 Bluetooth controller
>>
>> Signed-off-by: Rocky Liao <[email protected]>
>> ---
>> Documentation/devicetree/bindings/net/qualcomm-bluetooth.txt | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git
>> a/Documentation/devicetree/bindings/net/qualcomm-bluetooth.txt
>> b/Documentation/devicetree/bindings/net/qualcomm-bluetooth.txt
>> index 68b67d9db63a..87b7f9d22414 100644
>> --- a/Documentation/devicetree/bindings/net/qualcomm-bluetooth.txt
>> +++ b/Documentation/devicetree/bindings/net/qualcomm-bluetooth.txt
>> @@ -10,6 +10,7 @@ device the slave device is attached to.
>> Required properties:
>> - compatible: should contain one of the following:
>> * "qcom,qca6174-bt"
>> + * "qcom,qca6390-bt"
>> * "qcom,wcn3990-bt"
>> * "qcom,wcn3998-bt"
>
> now I am confused. Is this a DT platform or ACPI or both?
>
We need to support both, should I update ACPI part in this doc as well?
> Regards
>
> Marcel


2019-12-13 07:38:15

by Marcel Holtmann

[permalink] [raw]
Subject: Re: [PATCH v1 2/2] dt-bindings: net: bluetooth: Add device tree bindings for QCA6390

Hi Rocky,

>>> Add compatible string for the Qualcomm QCA6390 Bluetooth controller
>>> Signed-off-by: Rocky Liao <[email protected]>
>>> ---
>>> Documentation/devicetree/bindings/net/qualcomm-bluetooth.txt | 1 +
>>> 1 file changed, 1 insertion(+)
>>> diff --git a/Documentation/devicetree/bindings/net/qualcomm-bluetooth.txt b/Documentation/devicetree/bindings/net/qualcomm-bluetooth.txt
>>> index 68b67d9db63a..87b7f9d22414 100644
>>> --- a/Documentation/devicetree/bindings/net/qualcomm-bluetooth.txt
>>> +++ b/Documentation/devicetree/bindings/net/qualcomm-bluetooth.txt
>>> @@ -10,6 +10,7 @@ device the slave device is attached to.
>>> Required properties:
>>> - compatible: should contain one of the following:
>>> * "qcom,qca6174-bt"
>>> + * "qcom,qca6390-bt"
>>> * "qcom,wcn3990-bt"
>>> * "qcom,wcn3998-bt"
>> now I am confused. Is this a DT platform or ACPI or both?
> We need to support both, should I update ACPI part in this doc as well?

this patch is fine the, but the other one would be better if you split it in DT and ACPI support.

Regards

Marcel