2018-02-02 15:01:44

by SF Markus Elfring

Subject: [PATCH 0/2] i2c-puv3: Adjustments for puv3_i2c_probe()

From: Markus Elfring <[email protected]>
Date: Fri, 2 Feb 2018 15:54:32 +0100

Two update suggestions were taken into account
from static source code analysis.

Markus Elfring (2):
Delete an error message for a failed memory allocation
Improve a size determination

drivers/i2c/busses/i2c-puv3.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

--
2.16.1

2018-02-02 15:02:48

by SF Markus Elfring

Subject: [PATCH 1/2] i2c-puv3: Delete an error message for a failed memory allocation in puv3_i2c_probe()

From: Markus Elfring <[email protected]>
Date: Fri, 2 Feb 2018 15:41:26 +0100

Omit an extra message for a memory allocation failure in this function.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <[email protected]>
---
drivers/i2c/busses/i2c-puv3.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/i2c/busses/i2c-puv3.c b/drivers/i2c/busses/i2c-puv3.c
index 287088b8c4c8..5bd001d01bef 100644
--- a/drivers/i2c/busses/i2c-puv3.c
+++ b/drivers/i2c/busses/i2c-puv3.c
@@ -198,7 +198,6 @@ static int puv3_i2c_probe(struct platform_device *pdev)

adapter = kzalloc(sizeof(struct i2c_adapter), GFP_KERNEL);
if (adapter == NULL) {
- dev_err(&pdev->dev, "can't allocate interface!\n");
rc = -ENOMEM;
goto fail_nomem;
}
--
2.16.1

2018-02-02 15:04:47

by SF Markus Elfring

Subject: [PATCH 2/2] i2c-puv3: Improve a size determination in puv3_i2c_probe()

From: Markus Elfring <[email protected]>
Date: Fri, 2 Feb 2018 15:43:21 +0100

Replace the specification of a data structure by a pointer dereference
as the parameter for the operator "sizeof" to make the corresponding size
determination a bit safer according to the Linux coding style convention.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <[email protected]>
---
drivers/i2c/busses/i2c-puv3.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/i2c/busses/i2c-puv3.c b/drivers/i2c/busses/i2c-puv3.c
index 5bd001d01bef..929fd12b92de 100644
--- a/drivers/i2c/busses/i2c-puv3.c
+++ b/drivers/i2c/busses/i2c-puv3.c
@@ -196,7 +196,7 @@ static int puv3_i2c_probe(struct platform_device *pdev)
if (!request_mem_region(mem->start, resource_size(mem), "puv3_i2c"))
return -EBUSY;

- adapter = kzalloc(sizeof(struct i2c_adapter), GFP_KERNEL);
+ adapter = kzalloc(sizeof(*adapter), GFP_KERNEL);
if (adapter == NULL) {
rc = -ENOMEM;
goto fail_nomem;
--
2.16.1