On Wed, 18 Dec 2019 17:10:41 +0800
Alex Shi <[email protected]> wrote:
> Let the people know where to complain... ;)
So I'd like to apply all of these changes; they look fine to me given that
I don't read Chinese...:) But I do have a couple of requests:
- Please combine the changes into a single patch; adding the translated
file, putting it into the toctree, and adding translator credit are all
a single action, in the end. There is no reason to split them apart.
- Changelogs like the above are not particularly helpful; please provide
changelogs in the usual kernel style describing what was done and why.
Thanks,
jon
> Signed-off-by: Alex Shi <[email protected]>
> Cc: Harry Wei <[email protected]>
> Cc: Jonathan Corbet <[email protected]>
> Cc: [email protected]
> Cc: [email protected]
> ---
> .../translations/zh_CN/process/embargoed-hardware-issues.rst | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/Documentation/translations/zh_CN/process/embargoed-hardware-issues.rst b/Documentation/translations/zh_CN/process/embargoed-hardware-issues.rst
> index 5bc583a41188..a0b956946ebf 100644
> --- a/Documentation/translations/zh_CN/process/embargoed-hardware-issues.rst
> +++ b/Documentation/translations/zh_CN/process/embargoed-hardware-issues.rst
> @@ -1,3 +1,8 @@
> +.. include:: ../disclaimer-zh_CN.rst
> +
> +:Original: :ref:`Documentation/process/embargoed-hardware-issues.rst`
> +:Translator: Alex Shi <[email protected]>
> +
> 被限制的硬件问题
> ================
>
在 2019/12/20 上午1:05, Jonathan Corbet 写道:
> Alex Shi <[email protected]> wrote:
>
>> Let the people know where to complain... ;)
> So I'd like to apply all of these changes; they look fine to me given that
> I don't read Chinese...:) But I do have a couple of requests:
>
> - Please combine the changes into a single patch; adding the translated
> file, putting it into the toctree, and adding translator credit are all
> a single action, in the end. There is no reason to split them apart.
>
> - Changelogs like the above are not particularly helpful; please provide
> changelogs in the usual kernel style describing what was done and why.
>
Thanks for quick response, Jon!
I will modified all yesterday patches according to your suggestion and Cc to more Chinese as reviewer.
Thanks
Alex