2020-02-25 18:04:10

by Michael Walle

Subject: [PATCH 1/3] arm64: dts: ls1028a: sl28: fix on-board EEPROMS

The module itself has another EEPROM at 50h on I2C4. The EEPROM on the
carriers is located at 57h on I2C3. Fix that in the device trees.

Signed-off-by: Michael Walle <[email protected]>
---
.../fsl-ls1028a-kontron-kbox-a-230-ls.dts | 6 +++---
.../fsl-ls1028a-kontron-sl28-var3-ads2.dts | 14 ++++++++------
.../dts/freescale/fsl-ls1028a-kontron-sl28.dts | 6 ++++++
3 files changed, 17 insertions(+), 9 deletions(-)

diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-kbox-a-230-ls.dts b/arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-kbox-a-230-ls.dts
index aaf3c04771c3..32f6c80414bc 100644
--- a/arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-kbox-a-230-ls.dts
+++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-kbox-a-230-ls.dts
@@ -18,10 +18,10 @@
"kontron,sl28", "fsl,ls1028a";
};

-&i2c4 {
- eeprom@50 {
+&i2c3 {
+ eeprom@57 {
compatible = "atmel,24c32";
- reg = <0x50>;
+ reg = <0x57>;
pagesize = <32>;
};
};
diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28-var3-ads2.dts b/arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28-var3-ads2.dts
index 20fd86746f94..ff4a43986290 100644
--- a/arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28-var3-ads2.dts
+++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28-var3-ads2.dts
@@ -80,6 +80,14 @@
};
};

+&i2c3 {
+ eeprom@57 {
+ compatible = "atmel,24c64";
+ reg = <0x57>;
+ pagesize = <32>;
+ };
+};
+
&i2c4 {
status = "okay";

@@ -92,12 +100,6 @@
assigned-clocks = <&mclk>;
assigned-clock-rates = <1250000>;
};
-
- eeprom@50 {
- compatible = "atmel,24c32";
- reg = <0x50>;
- pagesize = <32>;
- };
};

&sai5 {
diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28.dts b/arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28.dts
index c60a444ad09d..4ba6aae45ef1 100644
--- a/arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28.dts
+++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28.dts
@@ -181,6 +181,12 @@

&i2c4 {
status = "okay";
+
+ eeprom@50 {
+ compatible = "atmel,24c32";
+ reg = <0x50>;
+ pagesize = <32>;
+ };
};

&lpuart1 {
--
2.20.1

2020-03-11 07:17:52

by Shawn Guo

Subject: Re: [PATCH 1/3] arm64: dts: ls1028a: sl28: fix on-board EEPROMS

On Tue, Feb 25, 2020 at 06:57:54PM +0100, Michael Walle wrote:
> The module itself has another EEPROM at 50h on I2C4. The EEPROM on the
> carriers is located at 57h on I2C3. Fix that in the device trees.
>
> Signed-off-by: Michael Walle <[email protected]>

Doesn't apply to my branch.

Shawn

> ---
> .../fsl-ls1028a-kontron-kbox-a-230-ls.dts | 6 +++---
> .../fsl-ls1028a-kontron-sl28-var3-ads2.dts | 14 ++++++++------
> .../dts/freescale/fsl-ls1028a-kontron-sl28.dts | 6 ++++++
> 3 files changed, 17 insertions(+), 9 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-kbox-a-230-ls.dts b/arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-kbox-a-230-ls.dts
> index aaf3c04771c3..32f6c80414bc 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-kbox-a-230-ls.dts
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-kbox-a-230-ls.dts
> @@ -18,10 +18,10 @@
> "kontron,sl28", "fsl,ls1028a";
> };
>
> -&i2c4 {
> - eeprom@50 {
> +&i2c3 {
> + eeprom@57 {
> compatible = "atmel,24c32";
> - reg = <0x50>;
> + reg = <0x57>;
> pagesize = <32>;
> };
> };
> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28-var3-ads2.dts b/arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28-var3-ads2.dts
> index 20fd86746f94..ff4a43986290 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28-var3-ads2.dts
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28-var3-ads2.dts
> @@ -80,6 +80,14 @@
> };
> };
>
> +&i2c3 {
> + eeprom@57 {
> + compatible = "atmel,24c64";
> + reg = <0x57>;
> + pagesize = <32>;
> + };
> +};
> +
> &i2c4 {
> status = "okay";
>
> @@ -92,12 +100,6 @@
> assigned-clocks = <&mclk>;
> assigned-clock-rates = <1250000>;
> };
> -
> - eeprom@50 {
> - compatible = "atmel,24c32";
> - reg = <0x50>;
> - pagesize = <32>;
> - };
> };
>
> &sai5 {
> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28.dts b/arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28.dts
> index c60a444ad09d..4ba6aae45ef1 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28.dts
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28.dts
> @@ -181,6 +181,12 @@
>
> &i2c4 {
> status = "okay";
> +
> + eeprom@50 {
> + compatible = "atmel,24c32";
> + reg = <0x50>;
> + pagesize = <32>;
> + };
> };
>
> &lpuart1 {
> --
> 2.20.1
>

2020-03-11 07:30:19

by Michael Walle

Subject: Re: [PATCH 1/3] arm64: dts: ls1028a: sl28: fix on-board EEPROMS

Am 2020-03-11 08:16, schrieb Shawn Guo:
> On Tue, Feb 25, 2020 at 06:57:54PM +0100, Michael Walle wrote:
>> The module itself has another EEPROM at 50h on I2C4. The EEPROM on the
>> carriers is located at 57h on I2C3. Fix that in the device trees.
>>
>> Signed-off-by: Michael Walle <[email protected]>
>
> Doesn't apply to my branch.

Oh, sorry. there was a patch missing. I'll send a v2 shortly.

-michael