2023-11-01 07:41:25

by Bagas Sanjaya

[permalink] [raw]
Subject: Re: [PATCH] staging: vme: enhance the help paragraphs for clarity

[Cc'ing driver contributors found via get_maintainer.pl. Also Cc: Charles from
linux-doc mailing list as wording patches like this one most likely suit him.]

On Sun, Oct 29, 2023 at 06:03:46PM +0000, Dorine Tipo wrote:
> diff --git a/drivers/staging/vme_user/Kconfig b/drivers/staging/vme_user/Kconfig
> index d65cc5510649..65a3e769090d 100644
> --- a/drivers/staging/vme_user/Kconfig
> +++ b/drivers/staging/vme_user/Kconfig
> @@ -4,6 +4,11 @@ menuconfig VME_BUS
> depends on PCI
> help
> If you say Y here you get support for the VME bridge Framework.
> + The VME Bridge Framework provides a set of tools and drivers
> + for VMEbus systems, allowing seamless integration of VME devices
> + with your PCI-enabled hardware. Select 'Y' to enable this feature
> + if you have VMEbus-based hardware or intend to use VME devices in
> + your system.
>
> if VME_BUS
>
> @@ -14,7 +19,10 @@ config VME_TSI148
> depends on HAS_DMA
> help
> If you say Y here you get support for the Tundra TSI148 VME bridge
> - chip.
> + chip. This bridge chip provides compatibility for VMEbus systems, allowing
> + communication with various VME devices. If you have hardware that
> + includes the Tundra TSI148 VME bridge, or if you plan to use VME
> + devices with your system, choose 'Y' to enable this feature.

Dorine,

Are you sure that your description properly describes what these modules
are doing? And most importantly, when users select them as module (choose
M), what will the modules be named?

Confused...

--
An old man doll... just what I always wanted! - Clara


Attachments:
(No filename) (1.65 kB)
signature.asc (235.00 B)
Download all attachments

2023-11-01 08:13:48

by Greg Kroah-Hartman

[permalink] [raw]
Subject: Re: [PATCH] staging: vme: enhance the help paragraphs for clarity

On Wed, Nov 01, 2023 at 02:39:53PM +0700, Bagas Sanjaya wrote:
> [Cc'ing driver contributors found via get_maintainer.pl. Also Cc: Charles from
> linux-doc mailing list as wording patches like this one most likely suit him.]

Please do not, that's the responsibility of the outreachy applicant to
do, as it is documented very well what needs to happen here.

thanks,

greg k-h

2023-11-01 08:14:56

by Bagas Sanjaya

[permalink] [raw]
Subject: Re: [PATCH] staging: vme: enhance the help paragraphs for clarity

On 01/11/2023 15:09, Greg KH wrote:
> On Wed, Nov 01, 2023 at 02:39:53PM +0700, Bagas Sanjaya wrote:
>> [Cc'ing driver contributors found via get_maintainer.pl. Also Cc: Charles from
>> linux-doc mailing list as wording patches like this one most likely suit him.]
>
> Please do not, that's the responsibility of the outreachy applicant to
> do, as it is documented very well what needs to happen here.
>

OK, thanks!

--
An old man doll... just what I always wanted! - Clara