2017-11-18 08:52:13

by Arvind Yadav

[permalink] [raw]
Subject: [PATCH 5/10 v2] Input: cpcap-pwrbutton: Handle return value of platform_get_irq

platform_get_irq() can fail here and we must check its return value.

Signed-off-by: Arvind Yadav <[email protected]>
---
changes in v2 :
return irq instead of -ENODEV.

drivers/input/misc/cpcap-pwrbutton.c | 3 +++
1 file changed, 3 insertions(+)

diff --git a/drivers/input/misc/cpcap-pwrbutton.c b/drivers/input/misc/cpcap-pwrbutton.c
index 0abef63..3a0626b 100644
--- a/drivers/input/misc/cpcap-pwrbutton.c
+++ b/drivers/input/misc/cpcap-pwrbutton.c
@@ -57,6 +57,9 @@ static int cpcap_power_button_probe(struct platform_device *pdev)
int irq = platform_get_irq(pdev, 0);
int err;

+ if (irq < 0)
+ return irq;
+
button = devm_kmalloc(&pdev->dev, sizeof(*button), GFP_KERNEL);
if (!button)
return -ENOMEM;
--
2.7.4


From 1584361588789709667@xxx Sat Nov 18 00:29:15 +0000 2017
X-GM-THRID: 1584361588789709667
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread