The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is (mostly) ignored
and this typically results in resource leaks. To improve here there is a
quest to make the remove callback return void. In the first step of this
quest all drivers are converted to .remove_new() which already returns
void.
Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.
Cc: Uwe Kleine-König <[email protected]>
Signed-off-by: Yangtao Li <[email protected]>
---
drivers/mmc/host/sdhci-pic32.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/mmc/host/sdhci-pic32.c b/drivers/mmc/host/sdhci-pic32.c
index 6696b6bdd88e..7a0351a9c74e 100644
--- a/drivers/mmc/host/sdhci-pic32.c
+++ b/drivers/mmc/host/sdhci-pic32.c
@@ -210,7 +210,7 @@ static int pic32_sdhci_probe(struct platform_device *pdev)
return ret;
}
-static int pic32_sdhci_remove(struct platform_device *pdev)
+static void pic32_sdhci_remove(struct platform_device *pdev)
{
struct sdhci_host *host = platform_get_drvdata(pdev);
struct pic32_sdhci_priv *sdhci_pdata = sdhci_priv(host);
@@ -221,8 +221,6 @@ static int pic32_sdhci_remove(struct platform_device *pdev)
clk_disable_unprepare(sdhci_pdata->base_clk);
clk_disable_unprepare(sdhci_pdata->sys_clk);
sdhci_pltfm_free(pdev);
-
- return 0;
}
static const struct of_device_id pic32_sdhci_id_table[] = {
@@ -238,7 +236,7 @@ static struct platform_driver pic32_sdhci_driver = {
.of_match_table = of_match_ptr(pic32_sdhci_id_table),
},
.probe = pic32_sdhci_probe,
- .remove = pic32_sdhci_remove,
+ .remove_new = pic32_sdhci_remove,
};
module_platform_driver(pic32_sdhci_driver);
--
2.39.0
On 13/07/23 11:07, Yangtao Li wrote:
> The .remove() callback for a platform driver returns an int which makes
> many driver authors wrongly assume it's possible to do error handling by
> returning an error code. However the value returned is (mostly) ignored
> and this typically results in resource leaks. To improve here there is a
> quest to make the remove callback return void. In the first step of this
> quest all drivers are converted to .remove_new() which already returns
> void.
>
> Trivially convert this driver from always returning zero in the remove
> callback to the void returning variant.
>
> Cc: Uwe Kleine-König <[email protected]>
> Signed-off-by: Yangtao Li <[email protected]>
For the following patches:
[PATCH 09_58] mmc: sdhci-pic32: Convert to platform remove callback returning void - Yangtao Li <[email protected]> - 2023-07-13 1107
[PATCH 10_58] mmc: sdhci: milbeaut: Convert to platform remove callback returning void - Yangtao Li <[email protected]> - 2023-07-13 1107
[PATCH 12_58] mmc: sdhci-of-at91: Convert to platform remove callback returning void - Yangtao Li <[email protected]> - 2023-07-13 1107
[PATCH 15_58] mmc: sdhci-pxav3: Convert to platform remove callback returning void - Yangtao Li <[email protected]> - 2023-07-13 1107
[PATCH 19_58] mmc: xenon: Convert to platform remove callback returning void - Yangtao Li <[email protected]> - 2023-07-13 1107
[PATCH 20_58] mmc: sdhci-s3c: Convert to platform remove callback returning void - Yangtao Li <[email protected]> - 2023-07-13 1107
[PATCH 27_58] mmc: sdhci-of-arasan: Convert to platform remove callback returning void - Yangtao Li <[email protected]> - 2023-07-13 1107
[PATCH 28_58] mmc: sdhci-of-dwcmshc: Convert to platform remove callback returning void - Yangtao Li <[email protected]> - 2023-07-13 1107
[PATCH 33_58] mmc: sdhci-omap: Convert to platform remove callback returning void - Yangtao Li <[email protected]> - 2023-07-13 1107
[PATCH 34_58] mmc: sdhci-of-aspeed: Convert to platform remove callback returning void - Yangtao Li <[email protected]> - 2023-07-13 1107
[PATCH 36_58] mmc: sdhci-sprd: Convert to platform remove callback returning void - Yangtao Li <[email protected]> - 2023-07-13 1107
[PATCH 37_58] mmc: sdhci-tegra: Convert to platform remove callback returning void - Yangtao Li <[email protected]> - 2023-07-13 1107
[PATCH 38_58] mmc: sdhci-acpi: Convert to platform remove callback returning void - Yangtao Li <[email protected]> - 2023-07-13 1107
[PATCH 39_58] mmc: sdhci-esdhc-imx: Convert to platform remove callback returning void - Yangtao Li <[email protected]> - 2023-07-13 1107
[PATCH 40_58] mmc: sdhci-msm: Convert to platform remove callback returning void - Yangtao Li <[email protected]> - 2023-07-13 1107
[PATCH 47_58] mmc: sdhci-st: Convert to platform remove callback returning void - Yangtao Li <[email protected]> - 2023-07-13 1107
[PATCH 49_58] mmc: sdhci-esdhc-mcf: Convert to platform remove callback returning void - Yangtao Li <[email protected]> - 2023-07-13 1107
[PATCH 51_58] mmc: sdhci-spear: Convert to platform remove callback returning void - Yangtao Li <[email protected]> - 2023-07-13 1108
Acked-by: Adrian Hunter <[email protected]>