2009-11-10 19:14:43

by Jerome Glisse

Subject: [PATCH] drm/radeon/kms: disable load detection on TV output

Do like in the DDX don't try to load detect TV output, there is a lot
of false positive detection with those code. Seems to be isolated to
RS480/RC410 chipset thought. Need more investigations.

Signed-off-by: Jerome Glisse <[email protected]>
---
drivers/gpu/drm/radeon/radeon_connectors.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/radeon/radeon_connectors.c b/drivers/gpu/drm/radeon/radeon_connectors.c
index fce4c40..292b170 100644
--- a/drivers/gpu/drm/radeon/radeon_connectors.c
+++ b/drivers/gpu/drm/radeon/radeon_connectors.c
@@ -1015,7 +1015,7 @@ radeon_add_atom_connector(struct drm_device *dev,
ret = drm_connector_helper_add(&radeon_connector->base, &radeon_tv_connector_helper_funcs);
if (ret)
goto failed;
- radeon_connector->dac_load_detect = true;
+ radeon_connector->dac_load_detect = false;
drm_connector_attach_property(&radeon_connector->base,
rdev->mode_info.load_detect_property,
1);
@@ -1148,7 +1148,7 @@ radeon_add_legacy_connector(struct drm_device *dev,
ret = drm_connector_helper_add(&radeon_connector->base, &radeon_tv_connector_helper_funcs);
if (ret)
goto failed;
- radeon_connector->dac_load_detect = true;
+ radeon_connector->dac_load_detect = false;
drm_connector_attach_property(&radeon_connector->base,
rdev->mode_info.load_detect_property,
1);
--
1.6.5.2

2009-11-10 20:59:20

by Dave Airlie

Subject: Re: [PATCH] drm/radeon/kms: disable load detection on TV output

> Do like in the DDX don't try to load detect TV output, there is a lot
> of false positive detection with those code. Seems to be isolated to
> RS480/RC410 chipset thought. Need more investigations.
>

NAK, I've not seen any false positive bug reports other than rs480, and
I suspect that is some timing difference due to different ref clock, I've
tested this code on my r100/r200/r300 cards and seemed to always work
fine.

So just turn it off for rs480, I'm also seeing a lot of rs480 reporting tv
connectors that don't exist, has the person got a real connector?

Dave.

> Signed-off-by: Jerome Glisse
<[email protected]>
> ---
> drivers/gpu/drm/radeon/radeon_connectors.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/radeon/radeon_connectors.c b/drivers/gpu/drm/radeon/radeon_connectors.c
> index fce4c40..292b170 100644
> --- a/drivers/gpu/drm/radeon/radeon_connectors.c
> +++ b/drivers/gpu/drm/radeon/radeon_connectors.c
> @@ -1015,7 +1015,7 @@ radeon_add_atom_connector(struct drm_device *dev,
> ret = drm_connector_helper_add(&radeon_connector->base, &radeon_tv_connector_helper_funcs);
> if (ret)
> goto failed;
> - radeon_connector->dac_load_detect = true;
> + radeon_connector->dac_load_detect = false;
> drm_connector_attach_property(&radeon_connector->base,
> rdev->mode_info.load_detect_property,
> 1);
> @@ -1148,7 +1148,7 @@ radeon_add_legacy_connector(struct drm_device *dev,
> ret = drm_connector_helper_add(&radeon_connector->base, &radeon_tv_connector_helper_funcs);
> if (ret)
> goto failed;
> - radeon_connector->dac_load_detect = true;
> + radeon_connector->dac_load_detect = false;
> drm_connector_attach_property(&radeon_connector->base,
> rdev->mode_info.load_detect_property,
> 1);
>