2019-04-01 19:37:42

by Julia Lawall

[permalink] [raw]
Subject: [PATCH] drm/panfrost: fix odd_ptr_err.cocci warnings

From: kbuild test robot <[email protected]>

PTR_ERR should access the value just tested by IS_ERR

Generated by: scripts/coccinelle/tests/odd_ptr_err.cocci

Fixes: 10f21de123ac ("drm/panfrost: add support for reset lines")
CC: Neil Armstrong <[email protected]>
Signed-off-by: kbuild test robot <[email protected]>
Signed-off-by: Julia Lawall <[email protected]>
---

tree: https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git panfrost-rebase-v2
head: 10f21de123ac13b8c257528b0b1222ebb5650510
commit: 10f21de123ac13b8c257528b0b1222ebb5650510 [7/7] drm/panfrost: add support for reset lines
:::::: branch date: 10 hours ago
:::::: commit date: 10 hours ago

Please take the patch only if it's a positive warning. Thanks!

panfrost_device.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

--- a/drivers/gpu/drm/panfrost/panfrost_device.c
+++ b/drivers/gpu/drm/panfrost/panfrost_device.c
@@ -21,7 +21,8 @@ static int panfrost_reset_init(struct pa

pfdev->rstc = devm_reset_control_array_get(pfdev->dev, false, true);
if (IS_ERR(pfdev->rstc)) {
- dev_err(pfdev->dev, "get reset failed %ld\n", PTR_ERR(pfdev->clock));
+ dev_err(pfdev->dev, "get reset failed %ld\n",
+ PTR_ERR(pfdev->rstc));
return PTR_ERR(pfdev->rstc);
}