2019-10-09 19:43:27

by Paul Walmsley

Subject: [PATCH] riscv: dts: HiFive Unleashed: add default chosen/stdout-path

Add a default "stdout-path" to the kernel DTS file, as is present in many
of the board DTS files elsewhere in the kernel tree. With this line
present, earlyconsole can be enabled by simply passing "earlycon" on the
kernel command line. No specific device details are necessary, since the
kernel will use the stdout-path as the default.

Signed-off-by: Paul Walmsley <[email protected]>
---
Tested on a HiFive Unleashed using BBL.

arch/riscv/boot/dts/sifive/hifive-unleashed-a00.dts | 1 +
1 file changed, 1 insertion(+)

diff --git a/arch/riscv/boot/dts/sifive/hifive-unleashed-a00.dts b/arch/riscv/boot/dts/sifive/hifive-unleashed-a00.dts
index 104d334511cd..88cfcb96bf23 100644
--- a/arch/riscv/boot/dts/sifive/hifive-unleashed-a00.dts
+++ b/arch/riscv/boot/dts/sifive/hifive-unleashed-a00.dts
@@ -13,6 +13,7 @@
compatible = "sifive,hifive-unleashed-a00", "sifive,fu540-c000";

chosen {
+ stdout-path = "serial0";
};

cpus {
--
2.23.0

2019-10-09 22:58:18

by Atish Patra

Subject: Re: [PATCH] riscv: dts: HiFive Unleashed: add default chosen/stdout-path

On Wed, 2019-10-09 at 12:42 -0700, Paul Walmsley wrote:
> Add a default "stdout-path" to the kernel DTS file, as is present in
> many
> of the board DTS files elsewhere in the kernel tree. With this line
> present, earlyconsole can be enabled by simply passing "earlycon" on
> the
> kernel command line. No specific device details are necessary, since
> the
> kernel will use the stdout-path as the default.
>
> Signed-off-by: Paul Walmsley <[email protected]>
> ---
> Tested on a HiFive Unleashed using BBL.
>
> arch/riscv/boot/dts/sifive/hifive-unleashed-a00.dts | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/riscv/boot/dts/sifive/hifive-unleashed-a00.dts
> b/arch/riscv/boot/dts/sifive/hifive-unleashed-a00.dts
> index 104d334511cd..88cfcb96bf23 100644
> --- a/arch/riscv/boot/dts/sifive/hifive-unleashed-a00.dts
> +++ b/arch/riscv/boot/dts/sifive/hifive-unleashed-a00.dts
> @@ -13,6 +13,7 @@
> compatible = "sifive,hifive-unleashed-a00", "sifive,fu540-
> c000";
>
> chosen {
> + stdout-path = "serial0";
> };
>
> cpus {

Tested on a HiFive Unleashed using OpenSBI + U-Boot + Linux boot flow.

Once this patch is merged, we can remove stdout-path fix in OpenSBI for
unleashed platform as well.

Reviewed-by: Atish Patra <[email protected]>


--
Regards,
Atish