2022-04-07 20:20:19

by Mahak Gupta

Subject: Re: [PATCH] staging: rtl8712: fix camel case in function r8712_generate_ie

On Thu, Apr 7, 2022 at 5:44 PM Julia Lawall <[email protected]> wrote:
>
>
>
> On Thu, 7 Apr 2022, Mahak Gupta wrote:
>
> > Adhere to linux kernel coding style.
> >
> > Reported by checkpatch:
> >
> > CHECK: Avoid CamelCase: <beaconPeriod>
>
> As another patch, you could also adjust the structure field name.
>
> julia
>
> >
> > Signed-off-by: Mahak Gupta <[email protected]>
> > ---
> > drivers/staging/rtl8712/ieee80211.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/staging/rtl8712/ieee80211.c b/drivers/staging/rtl8712/ieee80211.c
> > index f926809b1021..7d8f1a29d18a 100644
> > --- a/drivers/staging/rtl8712/ieee80211.c
> > +++ b/drivers/staging/rtl8712/ieee80211.c
> > @@ -162,13 +162,13 @@ int r8712_generate_ie(struct registry_priv *registrypriv)
> > uint sz = 0;
> > struct wlan_bssid_ex *dev_network = &registrypriv->dev_network;
> > u8 *ie = dev_network->IEs;
> > - u16 beaconPeriod = (u16)dev_network->Configuration.BeaconPeriod;
> > + u16 beacon_period = (u16)dev_network->Configuration.BeaconPeriod;
> >
> > /*timestamp will be inserted by hardware*/
> > sz += 8;
> > ie += sz;
> > /*beacon interval : 2bytes*/
> > - *(__le16 *)ie = cpu_to_le16(beaconPeriod);
> > + *(__le16 *)ie = cpu_to_le16(beacon_period);
> > sz += 2;
> > ie += 2;
> > /*capability info*/
> > --
> > 2.17.1
> >
> >
> >

Sure, on it. Thanks.

Mahak

2022-04-07 21:06:43

by Julia Lawall

Subject: Re: [PATCH] staging: rtl8712: fix camel case in function r8712_generate_ie

On Thu, 7 Apr 2022, MAHAK GUPTA wrote:

> On Thu, Apr 7, 2022 at 5:44 PM Julia Lawall <[email protected]> wrote:
> >
> >
> >
> > On Thu, 7 Apr 2022, Mahak Gupta wrote:
> >
> > > Adhere to linux kernel coding style.
> > >
> > > Reported by checkpatch:
> > >
> > > CHECK: Avoid CamelCase: <beaconPeriod>
> >
> > As another patch, you could also adjust the structure field name.
> >
> > julia
> >
> > >
> > > Signed-off-by: Mahak Gupta <[email protected]>
> > > ---
> > > drivers/staging/rtl8712/ieee80211.c | 4 ++--
> > > 1 file changed, 2 insertions(+), 2 deletions(-)
> > >
> > > diff --git a/drivers/staging/rtl8712/ieee80211.c b/drivers/staging/rtl8712/ieee80211.c
> > > index f926809b1021..7d8f1a29d18a 100644
> > > --- a/drivers/staging/rtl8712/ieee80211.c
> > > +++ b/drivers/staging/rtl8712/ieee80211.c
> > > @@ -162,13 +162,13 @@ int r8712_generate_ie(struct registry_priv *registrypriv)
> > > uint sz = 0;
> > > struct wlan_bssid_ex *dev_network = &registrypriv->dev_network;
> > > u8 *ie = dev_network->IEs;
> > > - u16 beaconPeriod = (u16)dev_network->Configuration.BeaconPeriod;
> > > + u16 beacon_period = (u16)dev_network->Configuration.BeaconPeriod;
> > >
> > > /*timestamp will be inserted by hardware*/
> > > sz += 8;
> > > ie += sz;
> > > /*beacon interval : 2bytes*/
> > > - *(__le16 *)ie = cpu_to_le16(beaconPeriod);
> > > + *(__le16 *)ie = cpu_to_le16(beacon_period);
> > > sz += 2;
> > > ie += 2;
> > > /*capability info*/
> > > --
> > > 2.17.1
> > >
> > >
> > >
>
> Sure, on it. Thanks.

It's good not to top post, but you can put your response right under the
text you are responding to.

julia