2022-04-19 13:46:42

by Aliya Rahmani

Subject: [PATCH v2 0/3] staging: media: zoran: fix warnings reported by checkpatch

These patches address style issues found by checkpatch in the
zoran/videocodec.c file.

changes since v1: Rework commit description and subject.

Aliya Rahmani (3):
staging: media: zoran: use seq_puts() instead of seq_printf()
staging: media: zoran: else is not generally useful after a break or return
staging: media: zoran: avoid macro argument precedence issues

drivers/staging/media/zoran/videocodec.c | 9++++-----
1 file changed, 4 insertions(+), 5 deletions(-)


--
2.25.1

2022-04-19 16:49:50

by Julia Lawall

Subject: Re: [PATCH v2 0/3] staging: media: zoran: fix warnings reported by checkpatch

On Mon, 18 Apr 2022, Aliya Rahmani wrote:

> These patches address style issues found by checkpatch in the
> zoran/videocodec.c file.
>
> changes since v1: Rework commit description and subject.

The change description is not very specific. Does it affect all of the
patches, or are some unchanged?

julia

>
> Aliya Rahmani (3):
> staging: media: zoran: use seq_puts() instead of seq_printf()
> staging: media: zoran: else is not generally useful after a break or return
> staging: media: zoran: avoid macro argument precedence issues
>
> drivers/staging/media/zoran/videocodec.c | 9++++-----
> 1 file changed, 4 insertions(+), 5 deletions(-)
>
>
> --
> 2.25.1
>
>
>

2022-04-21 06:47:55

by Aliya Rahmani

Subject: [PATCH v2 1/3] staging: media: zoran: use seq_puts() instead of seq_printf()

Replace seq_printf() with seq_puts() for a constant format without
additional arguments, reported by checkpatch.

Signed-off-by: Aliya Rahmani <[email protected]>
---
drivers/staging/media/zoran/videocodec.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/media/zoran/videocodec.c b/drivers/staging/media/zoran/videocodec.c
index 3af7d02bd910..16a1f23a7f19 100644
--- a/drivers/staging/media/zoran/videocodec.c
+++ b/drivers/staging/media/zoran/videocodec.c
@@ -250,8 +250,8 @@ int videocodec_debugfs_show(struct seq_file *m)
struct codec_list *h = codeclist_top;
struct attached_list *a;

- seq_printf(m, "<S>lave or attached <M>aster name type flags magic ");
- seq_printf(m, "(connected as)\n");
+ seq_puts(m, "<S>lave or attached <M>aster name type flags magic ");
+ seq_puts(m, "(connected as)\n");

--
2.25.1

2022-04-21 14:49:08

by Aliya Rahmani

Subject: [PATCH v2 2/3] staging: media: zoran: else is not generally useful after a break or return

Remove the else without affecting the logic. Fixes the checkpatch warning: else is not generally useful after a break or return

Signed-off-by: Aliya Rahmani <[email protected]>
---
drivers/staging/media/zoran/videocodec.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/staging/media/zoran/videocodec.c b/drivers/staging/media/zoran/videocodec.c
index 16a1f23a7f19..19732a47c8bd 100644
--- a/drivers/staging/media/zoran/videocodec.c
+++ b/drivers/staging/media/zoran/videocodec.c
@@ -98,9 +98,8 @@ struct videocodec *videocodec_attach(struct videocodec_master *master)

h->attached += 1;
return codec;
- } else {
- kfree(codec);
}
+ kfree(codec);
}
h = h->next;
}
--
2.25.1