2009-01-10 02:16:56

by Alexander Beregalov

Subject: mtd/lpddr/qinfo_probe.c needs lpddr_cmds to be compiled

drivers/built-in.o: In function `lpddr_probe':
drivers/mtd/lpddr/qinfo_probe.c:215:
undefined reference to `lpddr_cmdset'

# CONFIG_MTD_LPDDR is not set
CONFIG_MTD_QINFO_PROBE=y

2009-01-10 05:17:20

by Randy Dunlap

Subject: Re: mtd/lpddr/qinfo_probe.c needs lpddr_cmds to be compiled

Alexander Beregalov wrote:
> drivers/built-in.o: In function `lpddr_probe':
> drivers/mtd/lpddr/qinfo_probe.c:215:
> undefined reference to `lpddr_cmdset'
>
> # CONFIG_MTD_LPDDR is not set
> CONFIG_MTD_QINFO_PROBE=y
> --

This patch has been posted, just needs to be merged (hint):
---


Signed-off-by: Alexey Korolev <[email protected]>
---
diff --git a/drivers/mtd/lpddr/Kconfig b/drivers/mtd/lpddr/Kconfig
index acd4ea9..5a401d8 100644
--- a/drivers/mtd/lpddr/Kconfig
+++ b/drivers/mtd/lpddr/Kconfig
@@ -12,6 +12,7 @@ config MTD_LPDDR
DDR memories, intended for battery-operated systems.

config MTD_QINFO_PROBE
+ depends on MTD_LPDDR
tristate "Detect flash chips by QINFO probe"
help
Device Information for LPDDR chips is offered through the Overlay

2009-01-11 10:03:51

by Alexey Korolev

Subject: Re: mtd/lpddr/qinfo_probe.c needs lpddr_cmds to be compiled

Hi Randy,

I've just checked 2.6.29-rc1. It contains LPDDR patches but does not contain this patch.
Do you know whom I should ask to make this included?

Thanks,
Alexey

> > drivers/built-in.o: In function `lpddr_probe':
> > drivers/mtd/lpddr/qinfo_probe.c:215:
> > undefined reference to `lpddr_cmdset'
> >
> > # CONFIG_MTD_LPDDR is not set
> > CONFIG_MTD_QINFO_PROBE=y
> > --
>
> This patch has been posted, just needs to be merged (hint):
> ---
>
>
> Signed-off-by: Alexey Korolev <[email protected]>
> ---
> diff --git a/drivers/mtd/lpddr/Kconfig b/drivers/mtd/lpddr/Kconfig
> index acd4ea9..5a401d8 100644
> --- a/drivers/mtd/lpddr/Kconfig
> +++ b/drivers/mtd/lpddr/Kconfig
> @@ -12,6 +12,7 @@ config MTD_LPDDR
> DDR memories, intended for battery-operated systems.
>
> config MTD_QINFO_PROBE
> + depends on MTD_LPDDR
> tristate "Detect flash chips by QINFO probe"
> help
> Device Information for LPDDR chips is offered through the Overlay
>
>

2009-01-11 16:52:19

by Randy Dunlap

Subject: Re: mtd/lpddr/qinfo_probe.c needs lpddr_cmds to be compiled

Alexey Korolev wrote:
> Hi Randy,
>
> I've just checked 2.6.29-rc1. It contains LPDDR patches but does not contain this patch.
> Do you know whom I should ask to make this included?

MAINTAINERS file:

MEMORY TECHNOLOGY DEVICES (MTD)
P: David Woodhouse
M: [email protected]

> Thanks,
> Alexey
>
>>> drivers/built-in.o: In function `lpddr_probe':
>>> drivers/mtd/lpddr/qinfo_probe.c:215:
>>> undefined reference to `lpddr_cmdset'
>>>
>>> # CONFIG_MTD_LPDDR is not set
>>> CONFIG_MTD_QINFO_PROBE=y
>>> --
>> This patch has been posted, just needs to be merged (hint):
>> ---
>>
>>
>> Signed-off-by: Alexey Korolev <[email protected]>
>> ---
>> diff --git a/drivers/mtd/lpddr/Kconfig b/drivers/mtd/lpddr/Kconfig
>> index acd4ea9..5a401d8 100644
>> --- a/drivers/mtd/lpddr/Kconfig
>> +++ b/drivers/mtd/lpddr/Kconfig
>> @@ -12,6 +12,7 @@ config MTD_LPDDR
>> DDR memories, intended for battery-operated systems.
>>
>> config MTD_QINFO_PROBE
>> + depends on MTD_LPDDR
>> tristate "Detect flash chips by QINFO probe"
>> help
>> Device Information for LPDDR chips is offered through the Overlay
>>
>>


--
~Randy

2009-01-11 18:16:29

by Alexey Korolev

Subject: Re: mtd/lpddr/qinfo_probe.c needs lpddr_cmds to be compiled

Randy,
Yes, it has alreay been merged today.

David,
Thank you very much!

>
> MAINTAINERS file:
>
> MEMORY TECHNOLOGY DEVICES (MTD)
> P: David Woodhouse
> M: [email protected]
>
> > Thanks,
> > Alexey
> >
> >>> drivers/built-in.o: In function `lpddr_probe':
> >>> drivers/mtd/lpddr/qinfo_probe.c:215:
> >>> undefined reference to `lpddr_cmdset'
> >>>
> >>> # CONFIG_MTD_LPDDR is not set
> >>> CONFIG_MTD_QINFO_PROBE=y
> >>> --
> >> This patch has been posted, just needs to be merged (hint):
> >> ---
> >>
> >>
> >> Signed-off-by: Alexey Korolev <[email protected]>
> >> ---
> >> diff --git a/drivers/mtd/lpddr/Kconfig b/drivers/mtd/lpddr/Kconfig
> >> index acd4ea9..5a401d8 100644
> >> --- a/drivers/mtd/lpddr/Kconfig
> >> +++ b/drivers/mtd/lpddr/Kconfig
> >> @@ -12,6 +12,7 @@ config MTD_LPDDR
> >> DDR memories, intended for battery-operated systems.
> >>
> >> config MTD_QINFO_PROBE
> >> + depends on MTD_LPDDR
> >> tristate "Detect flash chips by QINFO probe"
> >> help
> >> Device Information for LPDDR chips is offered through the Overlay
> >>
> >>
>
>
> --
> ~Randy
>
> ______________________________________________________
> Linux MTD discussion mailing list
> http://lists.infradead.org/mailman/listinfo/linux-mtd/
>