2011-02-02 21:42:02

by Thomas Gleixner

Subject: [patch 7/8] m68knommu: 5772: Replace private irq flow handler

That handler lacks the minimal checks for action being zero etc. Keep
the weird flow - ack before handling - intact and call into
handle_simple_irq which does the right thing.

Signed-off-by: Thomas Gleixner <[email protected]>
Cc: Greg Ungerer <[email protected]>
---
arch/m68knommu/platform/5272/intc.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)

Index: linux-2.6-tip/arch/m68knommu/platform/5272/intc.c
===================================================================
--- linux-2.6-tip.orig/arch/m68knommu/platform/5272/intc.c
+++ linux-2.6-tip/arch/m68knommu/platform/5272/intc.c
@@ -137,11 +137,8 @@ static int intc_irq_set_type(unsigned in
*/
static void intc_external_irq(unsigned int irq, struct irq_desc *desc)
{
- kstat_incr_irqs_this_cpu(irq, desc);
- desc->status |= IRQ_INPROGRESS;
desc->chip->ack(irq);
- handle_IRQ_event(irq, desc->action);
- desc->status &= ~IRQ_INPROGRESS;
+ handle_simple_irq(irq, desc);
}

static struct irq_chip intc_irq_chip = {

2011-02-02 22:29:56

by Greg Ungerer

Subject: Re: [patch 7/8] m68knommu: 5772: Replace private irq flow handler

Hi Thomas,

On 03/02/11 07:41, Thomas Gleixner wrote:
> That handler lacks the minimal checks for action being zero etc. Keep
> the weird flow - ack before handling - intact and call into
> handle_simple_irq which does the right thing.
>
> Signed-off-by: Thomas Gleixner <[email protected]>
> Cc: Greg Ungerer <[email protected]>

Acked-by: Greg Ungerer <[email protected]>

(I can't test this change for a week or two at least, I don't
have access to any 5272 based boards at the moment.)

Do you want me to push it through the m68knommu tree,
or are you going to do that yourself?

Regards
Greg


> ---
> arch/m68knommu/platform/5272/intc.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> Index: linux-2.6-tip/arch/m68knommu/platform/5272/intc.c
> ===================================================================
> --- linux-2.6-tip.orig/arch/m68knommu/platform/5272/intc.c
> +++ linux-2.6-tip/arch/m68knommu/platform/5272/intc.c
> @@ -137,11 +137,8 @@ static int intc_irq_set_type(unsigned in
> */
> static void intc_external_irq(unsigned int irq, struct irq_desc *desc)
> {
> - kstat_incr_irqs_this_cpu(irq, desc);
> - desc->status |= IRQ_INPROGRESS;
> desc->chip->ack(irq);
> - handle_IRQ_event(irq, desc->action);
> - desc->status &= ~IRQ_INPROGRESS;
> + handle_simple_irq(irq, desc);
> }
>
> static struct irq_chip intc_irq_chip = {

--
------------------------------------------------------------------------
Greg Ungerer -- Principal Engineer EMAIL: [email protected]
SnapGear Group, McAfee PHONE: +61 7 3435 2888
8 Gardner Close FAX: +61 7 3217 5323
Milton, QLD, 4064, Australia WEB: http://www.SnapGear.com

2011-02-02 22:38:07

by Thomas Gleixner

Subject: Re: [patch 7/8] m68knommu: 5772: Replace private irq flow handler

On Thu, 3 Feb 2011, Greg Ungerer wrote:

>
> Hi Thomas,
>
> On 03/02/11 07:41, Thomas Gleixner wrote:
> > That handler lacks the minimal checks for action being zero etc. Keep
> > the weird flow - ack before handling - intact and call into
> > handle_simple_irq which does the right thing.
> >
> > Signed-off-by: Thomas Gleixner <[email protected]>
> > Cc: Greg Ungerer <[email protected]>
>
> Acked-by: Greg Ungerer <[email protected]>
>
> (I can't test this change for a week or two at least, I don't
> have access to any 5272 based boards at the moment.)
>
> Do you want me to push it through the m68knommu tree,
> or are you going to do that yourself?

If it does not conflict with your stuff, I'd prefer to push it myself,
so I can apply the depending patches as well.

Thanks,

tglx

2011-02-02 22:41:50

by Greg Ungerer

Subject: Re: [patch 7/8] m68knommu: 5772: Replace private irq flow handler

On 03/02/11 08:37, Thomas Gleixner wrote:
> On Thu, 3 Feb 2011, Greg Ungerer wrote:
>
>>
>> Hi Thomas,
>>
>> On 03/02/11 07:41, Thomas Gleixner wrote:
>>> That handler lacks the minimal checks for action being zero etc. Keep
>>> the weird flow - ack before handling - intact and call into
>>> handle_simple_irq which does the right thing.
>>>
>>> Signed-off-by: Thomas Gleixner<[email protected]>
>>> Cc: Greg Ungerer<[email protected]>
>>
>> Acked-by: Greg Ungerer<[email protected]>
>>
>> (I can't test this change for a week or two at least, I don't
>> have access to any 5272 based boards at the moment.)
>>
>> Do you want me to push it through the m68knommu tree,
>> or are you going to do that yourself?
>
> If it does not conflict with your stuff, I'd prefer to push it myself,
> so I can apply the depending patches as well.

No conflicts right now, and no planned changes in that area,
so feel free to push it yourself.

Regards
Greg


------------------------------------------------------------------------
Greg Ungerer -- Principal Engineer EMAIL: [email protected]
SnapGear Group, McAfee PHONE: +61 7 3435 2888
8 Gardner Close FAX: +61 7 3217 5323
Milton, QLD, 4064, Australia WEB: http://www.SnapGear.com