From: Casey Schaufler <[email protected]>
Given just how hard it is to find the code that uses MAY_APPEND
it's probably not a big surprise that this went unnoticed for so
long. The Smack rules loading code is incorrectly setting the
MAY_READ bit when MAY_APPEND is requested.
Signed-off-by: Casey Schaufler <[email protected]>
---
security/smack/smackfs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff -uprN -X linux-2.6/Documentation/dontdiff linux-2.6/security/smack/smackfs.c linux-0112/security/smack/smackfs.c
--- linux-2.6/security/smack/smackfs.c 2009-01-09 21:43:42.000000000 -0800
+++ linux-0112/security/smack/smackfs.c 2009-01-19 11:05:09.000000000 -0800
@@ -334,7 +334,7 @@ static ssize_t smk_write_load(struct fil
break;
case 'a':
case 'A':
- rule.smk_access |= MAY_READ;
+ rule.smk_access |= MAY_APPEND;
break;
default:
goto out;
On Tue, 27 Jan 2009, Casey Schaufler wrote:
> From: Casey Schaufler <[email protected]>
>
> Given just how hard it is to find the code that uses MAY_APPEND
> it's probably not a big surprise that this went unnoticed for so
> long. The Smack rules loading code is incorrectly setting the
> MAY_READ bit when MAY_APPEND is requested.
>
> Signed-off-by: Casey Schaufler <[email protected]>
Reviewed-by: James Morris <[email protected]>
--
James Morris
<[email protected]>
On Tue, 27 Jan 2009, Casey Schaufler wrote:
> From: Casey Schaufler <[email protected]>
>
> Given just how hard it is to find the code that uses MAY_APPEND
> it's probably not a big surprise that this went unnoticed for so
> long. The Smack rules loading code is incorrectly setting the
> MAY_READ bit when MAY_APPEND is requested.
>
> Signed-off-by: Casey Schaufler <[email protected]>
The patch was still corrupt (and you didn't format the subject line
properly).
A fixed version for Linus may be pulled via:
The following changes since commit e4a7ca29039e615ce13a61b9c6abfb2aa394e9a1:
Linus Torvalds (1):
Merge git://git.kernel.org/.../gregkh/usb-2.6
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/jmorris/security-testing-2.6 for-linus
Casey Schaufler (1):
smack: smackfs load append mode fix
security/smack/smackfs.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
--
James Morris
<[email protected]>