2010-02-08 11:00:17

by Xiaotian Feng

Subject: Re: [PATCH V2] selinux: fix memory leak in sel_make_bools

On 08/14/2009 02:06 PM, James Morris wrote:
> On Fri, 14 Aug 2009, Xiaotian Feng wrote:
>
>> In sel_make_bools, kernel allocates memory for bool_pending_names[i]
>> with security_get_bools. So if we just free bool_pending_names, those
>> memories for bool_pending_names[i] will be leaked.
>
> Thanks, applied and pushed to Linus.
This patch is missing or dropped? I'm not seeing this patch until
2.6.33-rc7, thanks.

2010-02-08 21:24:51

by James Morris

Subject: Re: [PATCH V2] selinux: fix memory leak in sel_make_bools

On Mon, 8 Feb 2010, Xiaotian Feng wrote:

> On 08/14/2009 02:06 PM, James Morris wrote:
> > On Fri, 14 Aug 2009, Xiaotian Feng wrote:
> >
> > > In sel_make_bools, kernel allocates memory for bool_pending_names[i]
> > > with security_get_bools. So if we just free bool_pending_names, those
> > > memories for bool_pending_names[i] will be leaked.
> >
> > Thanks, applied and pushed to Linus.
> This patch is missing or dropped? I'm not seeing this patch until 2.6.33-rc7,
> thanks.

Not sure what happened to that -- I pushed it to Linus, but it's not in
the tree for some reason. Now applied to

git://git.kernel.org/pub/scm/linux/kernel/git/jmorris/security-testing-2.6#next


--
James Morris
<[email protected]>