2012-08-03 04:37:36

by James Morris

[permalink] [raw]
Subject: Re: [PATCH] samples/seccomp: fix endianness bug in LO_ARG define

On Tue, 31 Jul 2012, Kees Cook wrote:

> On Tue, Jul 31, 2012 at 7:15 AM, Heiko Carstens
> <[email protected]> wrote:
> > From: Heiko Carstens <[email protected]>
> >
> > The LO_ARG define needs to consider endianness also for 32 bit builds.
> >
> > The "bpf_fancy" test case didn't work on s390 in 32 bit and compat mode
> > because the LO_ARG define resulted in a BPF program which read the upper
> > halve of the 64 bit system call arguments instead of the lower halves.
> >
> > Signed-off-by: Heiko Carstens <[email protected]>
>
> Good catch; thanks for the fix!
>
> Acked-by: Kees Cook <[email protected]>

Applied to
git://git.kernel.org/pub/scm/linux/kernel/git/jmorris/linux-security.git next


--
James Morris
<[email protected]>