2009-10-09 09:41:41

by Jiri Kosina

Subject: [PATCH] CIRS: turn local_save_flags() + local_irq_disable()into local_irq_save()

[ This is just FYI. I have already queued this one in trivial tree. ]

This is a followup to my patches that fixed this all over the tree quite some
time ago. This one went unnoticed for some reason.

TLB handling for CRIS contains local_irq_disable() after local_save_flags().
Turn this into local_irq_save().

Signed-off-by: Jiri Kosina <[email protected]>
---

arch/cris/arch-v10/mm/fault.c | 3 +--
1 files changed, 1 insertions(+), 2 deletions(-)

diff --git a/arch/cris/arch-v10/mm/fault.c b/arch/cris/arch-v10/mm/fault.c
index 087a209..ed60588 100644
--- a/arch/cris/arch-v10/mm/fault.c
+++ b/arch/cris/arch-v10/mm/fault.c
@@ -80,8 +80,7 @@ handle_mmu_bus_fault(struct pt_regs *regs)
* do_page_fault may have flushed the TLB so we have to restore
* the MMU registers.
*/
- local_save_flags(flags);
- local_irq_disable();
+ local_irq_save(flags);
pmd = (pmd_t *)(pgd + pgd_index(address));
if (pmd_none(*pmd))
goto exit;
--
1.5.6

2009-10-09 10:53:00

by Jesper Nilsson

Subject: Re: [PATCH] CIRS: turn local_save_flags() + local_irq_disable()into local_irq_save()

On Fri, Oct 09, 2009 at 11:41:03AM +0200, Jiri Kosina wrote:
> [ This is just FYI. I have already queued this one in trivial tree. ]

> This is a followup to my patches that fixed this all over the tree quite some
> time ago. This one went unnoticed for some reason.
>
> TLB handling for CRIS contains local_irq_disable() after local_save_flags().
> Turn this into local_irq_save().

Thanks, that looks good.

/^JN - Jesper Nilsson
--
Jesper Nilsson -- [email protected]

2009-10-09 12:16:12

by Jiri Kosina

Subject: Re: [PATCH] CIRS: turn local_save_flags() + local_irq_disable()into local_irq_save()

On Fri, 9 Oct 2009, Jesper Nilsson wrote:

> > This is a followup to my patches that fixed this all over the tree quite some
> > time ago. This one went unnoticed for some reason.
> >
> > TLB handling for CRIS contains local_irq_disable() after local_save_flags().
> > Turn this into local_irq_save().
>
> Thanks, that looks good.

I will then add

Acked-by: Jesper Nilsson <[email protected]>

to it if you don't mind (the same for the old debug stuff removal).

Thanks,

--
Jiri Kosina
SUSE Labs, Novell Inc.

2009-10-09 12:46:55

by Jesper Nilsson

Subject: Re: [PATCH] CIRS: turn local_save_flags() + local_irq_disable()into local_irq_save()

On Fri, Oct 09, 2009 at 02:15:34PM +0200, Jiri Kosina wrote:
> On Fri, 9 Oct 2009, Jesper Nilsson wrote:
> > > This is a followup to my patches that fixed this all over the tree quite some
> > > time ago. This one went unnoticed for some reason.
> > > TLB handling for CRIS contains local_irq_disable() after local_save_flags().
> > > Turn this into local_irq_save().
> >
> > Thanks, that looks good.
>
> I will then add
>
> Acked-by: Jesper Nilsson <[email protected]>
>
> to it if you don't mind (the same for the old debug stuff removal).

Absolutely, and thank you. :-)

> Thanks,

> Jiri Kosina

/^JN - Jesper Nilsson
--
Jesper Nilsson -- [email protected]