2021-02-10 11:02:43

by Dan Carpenter

Subject: [PATCH] module: potential uninitialized return in module_kallsyms_on_each_symbol()

Smatch complains that:

kernel/module.c:4472 module_kallsyms_on_each_symbol()
error: uninitialized symbol 'ret'.

This warning looks like it could be correct if the &modules list is
empty.

Fixes: 013c1667cf78 ("kallsyms: refactor {,module_}kallsyms_on_each_symbol")
Signed-off-by: Dan Carpenter <[email protected]>
---
kernel/module.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/module.c b/kernel/module.c
index 95186c9d81ea..9bd3c821d029 100644
--- a/kernel/module.c
+++ b/kernel/module.c
@@ -4447,7 +4447,7 @@ int module_kallsyms_on_each_symbol(int (*fn)(void *, const char *,
{
struct module *mod;
unsigned int i;
- int ret;
+ int ret = 0;

mutex_lock(&module_mutex);
list_for_each_entry(mod, &modules, list) {
--
2.30.0

2021-02-10 12:04:23

by Christoph Hellwig

Subject: Re: [PATCH] module: potential uninitialized return in module_kallsyms_on_each_symbol()

Looks good:

Reviewed-by: Christoph Hellwig <[email protected]>

2021-02-10 12:15:35

by Miroslav Benes

Subject: Re: [PATCH] module: potential uninitialized return in module_kallsyms_on_each_symbol()

On Wed, 10 Feb 2021, Dan Carpenter wrote:

> Smatch complains that:
>
> kernel/module.c:4472 module_kallsyms_on_each_symbol()
> error: uninitialized symbol 'ret'.
>
> This warning looks like it could be correct if the &modules list is
> empty.
>
> Fixes: 013c1667cf78 ("kallsyms: refactor {,module_}kallsyms_on_each_symbol")
> Signed-off-by: Dan Carpenter <[email protected]>

Reviewed-by: Miroslav Benes <[email protected]>

M

2021-02-10 16:22:36

by Jessica Yu

Subject: Re: [PATCH] module: potential uninitialized return in module_kallsyms_on_each_symbol()

+++ Dan Carpenter [10/02/21 13:57 +0300]:
>Smatch complains that:
>
> kernel/module.c:4472 module_kallsyms_on_each_symbol()
> error: uninitialized symbol 'ret'.
>
>This warning looks like it could be correct if the &modules list is
>empty.
>
>Fixes: 013c1667cf78 ("kallsyms: refactor {,module_}kallsyms_on_each_symbol")
>Signed-off-by: Dan Carpenter <[email protected]>

Applied, thanks!

Jessica