2022-09-30 04:25:57

by Marc Aurèle La France

[permalink] [raw]
Subject: Re: [PATCH] ext4: Register ext[23] support only after successful ext4 registration

On Thu, 29 Sep 2022, Theodore Ts'o wrote:
> On Wed, Aug 10, 2022 at 02:20:45PM -0600, Marc Aurèle La France wrote:
>> Register ext4 as a "replacement" for ext2 and ext3 only after ext4 itself has
>> been successfully registered. As a side effect, this allows
>> unregister_as_ext[23]() to be inlined.

> The corrent ordering is deliberate; it allows file systems that have
> ext2 and ext3 only file system features will be reported as using ext2
> and ext3 in /proc/mounts. This doesn't matter quite as much, but it
> could potentially break userspace if a legacy file system that only
> has ext2 file system features is mounted and reported as ext4.

> So sorry, I can't take this change.

Fair enough. Thanks for responding.

Marc.