2019-05-16 14:51:32

by Alex Williamson

Subject: Re: [PATCH] vfio: vfio_pci_nvlink2: use a vma helper function

[Cc Alexey + kvm]

On Thu, 16 May 2019 20:38:26 +0800
"[email protected]" <[email protected]> wrote:

> Use a vma helper function to simply code.
>
> Signed-off-by: Peng Hao <[email protected]>
> ---
>  drivers/vfio/pci/vfio_pci_nvlink2.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/vfio/pci/vfio_pci_nvlink2.c b/drivers/vfio/pci/vfio_pci_nvlink2.c
> index 32f695ffe128..dc42aa0e47f6 100644
> --- a/drivers/vfio/pci/vfio_pci_nvlink2.c
> +++ b/drivers/vfio/pci/vfio_pci_nvlink2.c
> @@ -161,8 +161,7 @@ static int vfio_pci_nvgpu_mmap(struct vfio_pci_device *vdev,
>  
>   atomic_inc(&data->mm->mm_count);
>   ret = (int) mm_iommu_newdev(data->mm, data->useraddr,
> - (vma->vm_end - vma->vm_start) >> PAGE_SHIFT,
> - data->gpu_hpa, &data->mem);
> + vma_pages(vma), data->gpu_hpa, &data->mem);
>  
>   trace_vfio_pci_nvgpu_mmap(vdev->pdev, data->gpu_hpa, data->useraddr,
>   vma->vm_end - vma->vm_start, ret);
> -- 
> 2.20.1

2019-05-20 06:02:47

by Alexey Kardashevskiy

Subject: Re: [PATCH] vfio: vfio_pci_nvlink2: use a vma helper function

On 17/05/2019 00:48, Alex Williamson wrote:
> [Cc Alexey + kvm]
>
> On Thu, 16 May 2019 20:38:26 +0800
> "[email protected]" <[email protected]> wrote:
>
>> Use a vma helper function to simply code.
>>
>> Signed-off-by: Peng Hao <[email protected]>
>> ---
>>  drivers/vfio/pci/vfio_pci_nvlink2.c | 3 +--
>>  1 file changed, 1 insertion(+), 2 deletions(-)
>>
>> diff --git a/drivers/vfio/pci/vfio_pci_nvlink2.c b/drivers/vfio/pci/vfio_pci_nvlink2.c
>> index 32f695ffe128..dc42aa0e47f6 100644
>> --- a/drivers/vfio/pci/vfio_pci_nvlink2.c
>> +++ b/drivers/vfio/pci/vfio_pci_nvlink2.c
>> @@ -161,8 +161,7 @@ static int vfio_pci_nvgpu_mmap(struct vfio_pci_device *vdev,
>>  
>>   atomic_inc(&data->mm->mm_count);
>>   ret = (int) mm_iommu_newdev(data->mm, data->useraddr,
>> - (vma->vm_end - vma->vm_start) >> PAGE_SHIFT,
>> - data->gpu_hpa, &data->mem);
>> + vma_pages(vma), data->gpu_hpa, &data->mem);


I did not realize we have been having this mighty helper since 2005 :)

Reviewed-by: Alexey Kardashevskiy <[email protected]>



>>  
>>   trace_vfio_pci_nvgpu_mmap(vdev->pdev, data->gpu_hpa, data->useraddr,
>>   vma->vm_end - vma->vm_start, ret);
>> -- 
>> 2.20.1

--
Alexey