2023-01-23 15:18:04

by Krzysztof Kozlowski

[permalink] [raw]
Subject: [PATCH 1/2] arm64: dts: mediatek: mt7622: drop serial clock-names

The serial node does not use clock-names:

mt7622-bananapi-bpi-r64.dtb: serial@1100c000: Unevaluated properties are not allowed ('clock-names' was unexpected)

Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
arch/arm64/boot/dts/mediatek/mt7622.dtsi | 1 -
1 file changed, 1 deletion(-)

diff --git a/arch/arm64/boot/dts/mediatek/mt7622.dtsi b/arch/arm64/boot/dts/mediatek/mt7622.dtsi
index 146e18b5b1f4..62487a3c4db1 100644
--- a/arch/arm64/boot/dts/mediatek/mt7622.dtsi
+++ b/arch/arm64/boot/dts/mediatek/mt7622.dtsi
@@ -526,7 +526,6 @@ btif: serial@1100c000 {
reg = <0 0x1100c000 0 0x1000>;
interrupts = <GIC_SPI 90 IRQ_TYPE_LEVEL_LOW>;
clocks = <&pericfg CLK_PERI_BTIF_PD>;
- clock-names = "main";
reg-shift = <2>;
reg-io-width = <4>;
status = "disabled";
--
2.34.1



2023-01-23 15:18:14

by Krzysztof Kozlowski

[permalink] [raw]
Subject: [PATCH 2/2] arm64: dts: mediatek: mt8183: drop double interrupts

The DTSI comes with interrupts property, so it must be removed if
interrupts-extended are used:

mt8183-kukui-jacuzzi-cozmo.dtb: serial@11003000: More than one condition true in oneOf schema:

Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi | 1 +
1 file changed, 1 insertion(+)

diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi b/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi
index 821a51e458c5..fbe14b13051a 100644
--- a/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi
+++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi
@@ -963,6 +963,7 @@ &uart1 {
pinctrl-0 = <&uart1_pins_default>;
pinctrl-1 = <&uart1_pins_sleep>;
status = "okay";
+ /delete-property/ interrupts;
interrupts-extended = <&sysirq GIC_SPI 92 IRQ_TYPE_LEVEL_LOW>,
<&pio 121 IRQ_TYPE_EDGE_FALLING>;

--
2.34.1


Subject: Re: [PATCH 1/2] arm64: dts: mediatek: mt7622: drop serial clock-names

Il 23/01/23 16:16, Krzysztof Kozlowski ha scritto:
> The serial node does not use clock-names:
>
> mt7622-bananapi-bpi-r64.dtb: serial@1100c000: Unevaluated properties are not allowed ('clock-names' was unexpected)
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>

Reviewed-by: AngeloGioacchino Del Regno <[email protected]>


Subject: Re: [PATCH 2/2] arm64: dts: mediatek: mt8183: drop double interrupts

Il 23/01/23 16:16, Krzysztof Kozlowski ha scritto:
> The DTSI comes with interrupts property, so it must be removed if
> interrupts-extended are used:
>
> mt8183-kukui-jacuzzi-cozmo.dtb: serial@11003000: More than one condition true in oneOf schema:
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>

Reviewed-by: AngeloGioacchino Del Regno <[email protected]>



2023-01-25 14:32:39

by Matthias Brugger

[permalink] [raw]
Subject: Re: [PATCH 1/2] arm64: dts: mediatek: mt7622: drop serial clock-names



On 23/01/2023 16:16, Krzysztof Kozlowski wrote:
> The serial node does not use clock-names:
>
> mt7622-bananapi-bpi-r64.dtb: serial@1100c000: Unevaluated properties are not allowed ('clock-names' was unexpected)
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>

Both applied, thanks!

> ---
> arch/arm64/boot/dts/mediatek/mt7622.dtsi | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/mediatek/mt7622.dtsi b/arch/arm64/boot/dts/mediatek/mt7622.dtsi
> index 146e18b5b1f4..62487a3c4db1 100644
> --- a/arch/arm64/boot/dts/mediatek/mt7622.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt7622.dtsi
> @@ -526,7 +526,6 @@ btif: serial@1100c000 {
> reg = <0 0x1100c000 0 0x1000>;
> interrupts = <GIC_SPI 90 IRQ_TYPE_LEVEL_LOW>;
> clocks = <&pericfg CLK_PERI_BTIF_PD>;
> - clock-names = "main";
> reg-shift = <2>;
> reg-io-width = <4>;
> status = "disabled";