2022-09-16 15:56:35

by Ruffalo Lavoisier

Subject: [PATCH 2] liquidio: CN23XX: delete repeated words, add missing words and fix typo in comment

- Delete the repeated word 'to' in the comment.

- Add the missing 'use' word within the sentence.

- Correct spelling on 'malformation'.

Signed-off-by: Ruffalo Lavoisier <[email protected]>
---
I have reflected all the reviews. Thanks !

drivers/net/ethernet/cavium/liquidio/cn23xx_pf_regs.h | 2 +-
drivers/net/ethernet/cavium/liquidio/cn23xx_vf_regs.h | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/ethernet/cavium/liquidio/cn23xx_pf_regs.h b/drivers/net/ethernet/cavium/liquidio/cn23xx_pf_regs.h
index 3f1c189646f4..244e27ea079c 100644
--- a/drivers/net/ethernet/cavium/liquidio/cn23xx_pf_regs.h
+++ b/drivers/net/ethernet/cavium/liquidio/cn23xx_pf_regs.h
@@ -88,7 +88,7 @@
#define CN23XX_SLI_PKT_IN_JABBER 0x29170
/* The input jabber is used to determine the TSO max size.
* Due to H/W limitation, this need to be reduced to 60000
- * in order to to H/W TSO and avoid the WQE malfarmation
+ * in order to use H/W TSO and avoid the WQE malformation
* PKO_BUG_24989_WQE_LEN
*/
#define CN23XX_DEFAULT_INPUT_JABBER 0xEA60 /*60000*/
diff --git a/drivers/net/ethernet/cavium/liquidio/cn23xx_vf_regs.h b/drivers/net/ethernet/cavium/liquidio/cn23xx_vf_regs.h
index d33dd8f4226f..e85449249670 100644
--- a/drivers/net/ethernet/cavium/liquidio/cn23xx_vf_regs.h
+++ b/drivers/net/ethernet/cavium/liquidio/cn23xx_vf_regs.h
@@ -37,7 +37,7 @@

/* The input jabber is used to determine the TSO max size.
* Due to H/W limitation, this need to be reduced to 60000
- * in order to to H/W TSO and avoid the WQE malfarmation
+ * in order to use H/W TSO and avoid the WQE malformation
* PKO_BUG_24989_WQE_LEN
*/
#define CN23XX_DEFAULT_INPUT_JABBER 0xEA60 /*60000*/
--
2.25.1

2022-09-16 17:01:04

by Randy Dunlap

Subject: Re: [PATCH 2] liquidio: CN23XX: delete repeated words, add missing words and fix typo in comment

Hi,

You missed one comment from v1 (see below).

Also, the Subject: should be in the format
[PATCH v3]
on your next version, please.

On 9/16/22 08:07, Ruffalo Lavoisier wrote:
> - Delete the repeated word 'to' in the comment.
>
> - Add the missing 'use' word within the sentence.
>
> - Correct spelling on 'malformation'.
>
> Signed-off-by: Ruffalo Lavoisier <[email protected]>
> ---
> I have reflected all the reviews. Thanks !
>
> drivers/net/ethernet/cavium/liquidio/cn23xx_pf_regs.h | 2 +-
> drivers/net/ethernet/cavium/liquidio/cn23xx_vf_regs.h | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/ethernet/cavium/liquidio/cn23xx_pf_regs.h b/drivers/net/ethernet/cavium/liquidio/cn23xx_pf_regs.h
> index 3f1c189646f4..244e27ea079c 100644
> --- a/drivers/net/ethernet/cavium/liquidio/cn23xx_pf_regs.h
> +++ b/drivers/net/ethernet/cavium/liquidio/cn23xx_pf_regs.h
> @@ -88,7 +88,7 @@
> #define CN23XX_SLI_PKT_IN_JABBER 0x29170
> /* The input jabber is used to determine the TSO max size.
> * Due to H/W limitation, this need to be reduced to 60000

this needs

> - * in order to to H/W TSO and avoid the WQE malfarmation
> + * in order to use H/W TSO and avoid the WQE malformation
> * PKO_BUG_24989_WQE_LEN
> */
> #define CN23XX_DEFAULT_INPUT_JABBER 0xEA60 /*60000*/
> diff --git a/drivers/net/ethernet/cavium/liquidio/cn23xx_vf_regs.h b/drivers/net/ethernet/cavium/liquidio/cn23xx_vf_regs.h
> index d33dd8f4226f..e85449249670 100644
> --- a/drivers/net/ethernet/cavium/liquidio/cn23xx_vf_regs.h
> +++ b/drivers/net/ethernet/cavium/liquidio/cn23xx_vf_regs.h
> @@ -37,7 +37,7 @@
>
> /* The input jabber is used to determine the TSO max size.
> * Due to H/W limitation, this need to be reduced to 60000

this needs

> - * in order to to H/W TSO and avoid the WQE malfarmation
> + * in order to use H/W TSO and avoid the WQE malformation
> * PKO_BUG_24989_WQE_LEN
> */
> #define CN23XX_DEFAULT_INPUT_JABBER 0xEA60 /*60000*/