2020-11-16 14:36:27

by Harald Arnesen

Subject: Linux 4.10-rc4 compile error

I get the following compile error, which reverting commit
ff828729be446b86957f7c294068758231cd2183 fixes (and the resulting kernel
boots fine).

$ make
...
CALL scripts/checksyscalls.sh
CALL scripts/atomic/check-atomics.sh
DESCEND objtool
CHK include/generated/compile.h
CHK kernel/kheaders_data.tar.xz
CC drivers/iommu/intel/dmar.o
drivers/iommu/intel/dmar.c: In function 'vf_inherit_msi_domain':
drivers/iommu/intel/dmar.c:338:59: error: 'struct pci_dev' has no member
named 'physfn'; did you mean 'is_physfn'?
338 | dev_set_msi_domain(&pdev->dev,
dev_get_msi_domain(&pdev->physfn->dev));
| ^~~~~~
| is_physfn
make[3]: *** [scripts/Makefile.build:283: drivers/iommu/intel/dmar.o]
Error 1
make[2]: *** [scripts/Makefile.build:500: drivers/iommu/intel] Error 2
make[1]: *** [scripts/Makefile.build:500: drivers/iommu] Error 2
make: *** [Makefile:1799: drivers] Error 2

--
Hilsen Harald

2020-11-16 21:52:03

by Thomas Gleixner

Subject: Re: Linux 4.10-rc4 compile error

On Mon, Nov 16 2020 at 15:32, Harald Arnesen wrote:
> I get the following compile error, which reverting commit
> ff828729be446b86957f7c294068758231cd2183 fixes (and the resulting kernel
> boots fine).
> CC drivers/iommu/intel/dmar.o
> drivers/iommu/intel/dmar.c: In function 'vf_inherit_msi_domain':
> drivers/iommu/intel/dmar.c:338:59: error: 'struct pci_dev' has no member
> named 'physfn'; did you mean 'is_physfn'?
> 338 | dev_set_msi_domain(&pdev->dev,
> dev_get_msi_domain(&pdev->physfn->dev));

I queued a fix already:

https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git/commit/?h=x86/urgent&id=8986f223bd777a73119f5d593c15b4d630ff49bb

Sorry for the wreckage.

Thanks,

tglx