2023-06-06 07:25:43

by Dan Carpenter

Subject: Re: [PATCH v2 1/1] test_firmware: return ENOMEM instead of ENOSPC on failed memory allocation

On Tue, Jun 06, 2023 at 09:08:10AM +0200, Mirsad Goran Todorovac wrote:
> In a couple of situations like
>
> name = kstrndup(buf, count, GFP_KERNEL);
> if (!name)
> return -ENOSPC;
>
> the error is not actually "No space left on device", but "Out of memory".
>
> It is semantically correct to return -ENOMEM in all failed kstrndup()
> and kzalloc() cases in this driver, as it is not a problem with disk
> space, but with kernel memory allocator failing allocation.
>
> The semantically correct should be:
>
> name = kstrndup(buf, count, GFP_KERNEL);
> if (!name)
> return -ENOMEM;
>
> Cc: Dan Carpenter <[email protected]>
> Cc: Takashi Iwai <[email protected]>
> Cc: Kees Cook <[email protected]>
> Cc: "Luis R. Rodriguez" <[email protected]>
> Cc: Scott Branden <[email protected]>
> Cc: Hans de Goede <[email protected]>
> Cc: Brian Norris <[email protected]>
> Fixes: c92316bf8e948 ("test_firmware: add batched firmware tests")
> Fixes: 0a8adf584759c ("test: add firmware_class loader test")
> Fixes: 548193cba2a7d ("test_firmware: add support for firmware_request_platform")
> Fixes: eb910947c82f9 ("test: firmware_class: add asynchronous request trigger")
> Fixes: 061132d2b9c95 ("test_firmware: add test custom fallback trigger")
> Fixes: 7feebfa487b92 ("test_firmware: add support for request_firmware_into_buf")
> Signed-off-by: Mirsad Goran Todorovac <[email protected]>
> ---

Thanks!

Reviewed-by: Dan Carpenter <[email protected]>

regards,
dan carpenter

2023-06-06 10:36:10

by Mirsad Todorovac

Subject: Re: [PATCH v2 1/1] test_firmware: return ENOMEM instead of ENOSPC on failed memory allocation

On 6/6/23 09:14, Dan Carpenter wrote:
> On Tue, Jun 06, 2023 at 09:08:10AM +0200, Mirsad Goran Todorovac wrote:
>> In a couple of situations like
>>
>> name = kstrndup(buf, count, GFP_KERNEL);
>> if (!name)
>> return -ENOSPC;
>>
>> the error is not actually "No space left on device", but "Out of memory".
>>
>> It is semantically correct to return -ENOMEM in all failed kstrndup()
>> and kzalloc() cases in this driver, as it is not a problem with disk
>> space, but with kernel memory allocator failing allocation.
>>
>> The semantically correct should be:
>>
>> name = kstrndup(buf, count, GFP_KERNEL);
>> if (!name)
>> return -ENOMEM;
>>
>> Cc: Dan Carpenter <[email protected]>
>> Cc: Takashi Iwai <[email protected]>
>> Cc: Kees Cook <[email protected]>
>> Cc: "Luis R. Rodriguez" <[email protected]>
>> Cc: Scott Branden <[email protected]>
>> Cc: Hans de Goede <[email protected]>
>> Cc: Brian Norris <[email protected]>
>> Fixes: c92316bf8e948 ("test_firmware: add batched firmware tests")
>> Fixes: 0a8adf584759c ("test: add firmware_class loader test")
>> Fixes: 548193cba2a7d ("test_firmware: add support for firmware_request_platform")
>> Fixes: eb910947c82f9 ("test: firmware_class: add asynchronous request trigger")
>> Fixes: 061132d2b9c95 ("test_firmware: add test custom fallback trigger")
>> Fixes: 7feebfa487b92 ("test_firmware: add support for request_firmware_into_buf")
>> Signed-off-by: Mirsad Goran Todorovac <[email protected]>
>> ---
>
> Thanks!

Thank you for reviewing the patch at such a short notice.
Though it is merely a code consistency fix.

Best regards,
Mirsad Todorovac

> Reviewed-by: Dan Carpenter <[email protected]>
>
> regards,
> dan carpenter

--
Mirsad Goran Todorovac
Sistem inženjer
Grafički fakultet | Akademija likovnih umjetnosti
Sveučilište u Zagrebu

System engineer
Faculty of Graphic Arts | Academy of Fine Arts
University of Zagreb, Republic of Croatia