2019-06-14 15:37:31

by Yue Haibing

Subject: [PATCH -next] drm/bridge: sii902x: Make sii902x_audio_digital_mute static

Fix sparse warning:

drivers/gpu/drm/bridge/sii902x.c:665:5: warning:
symbol 'sii902x_audio_digital_mute' was not declared. Should it be static?

Reported-by: Hulk Robot <[email protected]>
Signed-off-by: YueHaibing <[email protected]>
---
drivers/gpu/drm/bridge/sii902x.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/bridge/sii902x.c b/drivers/gpu/drm/bridge/sii902x.c
index dd7aa46..c2f97e5 100644
--- a/drivers/gpu/drm/bridge/sii902x.c
+++ b/drivers/gpu/drm/bridge/sii902x.c
@@ -662,7 +662,8 @@ static void sii902x_audio_shutdown(struct device *dev, void *data)
clk_disable_unprepare(sii902x->audio.mclk);
}

-int sii902x_audio_digital_mute(struct device *dev, void *data, bool enable)
+static int sii902x_audio_digital_mute(struct device *dev,
+ void *data, bool enable)
{
struct sii902x *sii902x = dev_get_drvdata(dev);

--
2.7.4

2019-07-04 07:47:18

by Andrzej Hajda

Subject: Re: [PATCH -next] drm/bridge: sii902x: Make sii902x_audio_digital_mute static

On 14.06.2019 17:36, YueHaibing wrote:
> Fix sparse warning:
>
> drivers/gpu/drm/bridge/sii902x.c:665:5: warning:
> symbol 'sii902x_audio_digital_mute' was not declared. Should it be static?
>
> Reported-by: Hulk Robot <[email protected]>
> Signed-off-by: YueHaibing <[email protected]>
> ---
> drivers/gpu/drm/bridge/sii902x.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/bridge/sii902x.c b/drivers/gpu/drm/bridge/sii902x.c
> index dd7aa46..c2f97e5 100644
> --- a/drivers/gpu/drm/bridge/sii902x.c
> +++ b/drivers/gpu/drm/bridge/sii902x.c
> @@ -662,7 +662,8 @@ static void sii902x_audio_shutdown(struct device *dev, void *data)
> clk_disable_unprepare(sii902x->audio.mclk);
> }
>
> -int sii902x_audio_digital_mute(struct device *dev, void *data, bool enable)
> +static int sii902x_audio_digital_mute(struct device *dev,
> + void *data, bool enable)
> {
> struct sii902x *sii902x = dev_get_drvdata(dev);
>


Thanks,


Applied to drm-misc-next.


Regards

Andrzej