2021-07-21 11:56:20

by Colin King

[permalink] [raw]
Subject: [PATCH] xen/events: remove redundant initialization of variable irq

From: Colin Ian King <[email protected]>

The variable irq is being initialized with a value that is never
read, it is being updated later on. The assignment is redundant and
can be removed.

Addresses-Coverity: ("Unused value")
Signed-off-by: Colin Ian King <[email protected]>
---
drivers/xen/events/events_base.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/xen/events/events_base.c b/drivers/xen/events/events_base.c
index d7e361fb0548..154daddbdcb4 100644
--- a/drivers/xen/events/events_base.c
+++ b/drivers/xen/events/events_base.c
@@ -1009,7 +1009,7 @@ static void __unbind_from_irq(unsigned int irq)
int xen_bind_pirq_gsi_to_irq(unsigned gsi,
unsigned pirq, int shareable, char *name)
{
- int irq = -1;
+ int irq;
struct physdev_irq irq_op;
int ret;

--
2.31.1


2021-07-21 21:04:45

by Juergen Gross

[permalink] [raw]
Subject: Re: [PATCH] xen/events: remove redundant initialization of variable irq

On 21.07.21 13:40, Colin King wrote:
> From: Colin Ian King <[email protected]>
>
> The variable irq is being initialized with a value that is never
> read, it is being updated later on. The assignment is redundant and
> can be removed.
>
> Addresses-Coverity: ("Unused value")
> Signed-off-by: Colin Ian King <[email protected]>

Reviewed-by: Juergen Gross <[email protected]>


Juergen


Attachments:
OpenPGP_0xB0DE9DD628BF132F.asc (3.06 kB)
OpenPGP public key
OpenPGP_signature (505.00 B)
OpenPGP digital signature
Download all attachments

2021-07-21 21:05:21

by Boris Ostrovsky

[permalink] [raw]
Subject: Re: [PATCH] xen/events: remove redundant initialization of variable irq


On 7/21/21 11:36 AM, Juergen Gross wrote:
> On 21.07.21 13:40, Colin King wrote:
>> From: Colin Ian King <[email protected]>
>>
>> The variable irq is being initialized with a value that is never
>> read, it is being updated later on. The assignment is redundant and
>> can be removed.
>>
>> Addresses-Coverity: ("Unused value")
>> Signed-off-by: Colin Ian King <[email protected]>
>
> Reviewed-by: Juergen Gross <[email protected]>



Applied to for-linus-5.14


-boris