LinuxLists.cc - [PATCH v2 1/5] dt-bindings: display: sitronix,st7735r: Convert to DT schema

2020-01-15 12:47:24

Subject: [PATCH v2 1/5] dt-bindings: display: sitronix,st7735r: Convert to DT schema

Convert the DT binding documentation for Sitronix ST7735R displays to DT
schema.

Add a reference to the Adafruit 1.8" LCD while at it.

Signed-off-by: Geert Uytterhoeven <[email protected]>
---
v2:
- New.
---
.../bindings/display/sitronix,st7735r.txt | 35 ----------
.../bindings/display/sitronix,st7735r.yaml | 65 +++++++++++++++++++
MAINTAINERS | 2 +-
3 files changed, 66 insertions(+), 36 deletions(-)
delete mode 100644 Documentation/devicetree/bindings/display/sitronix,st7735r.txt
create mode 100644 Documentation/devicetree/bindings/display/sitronix,st7735r.yaml

diff --git a/Documentation/devicetree/bindings/display/sitronix,st7735r.txt b/Documentation/devicetree/bindings/display/sitronix,st7735r.txt
deleted file mode 100644
index cd5c7186890a2be7..0000000000000000
--- a/Documentation/devicetree/bindings/display/sitronix,st7735r.txt
+++ /dev/null
@@ -1,35 +0,0 @@
-Sitronix ST7735R display panels
-
-This binding is for display panels using a Sitronix ST7735R controller in SPI
-mode.
-
-Required properties:
-- compatible: "jianda,jd-t18003-t01", "sitronix,st7735r"
-- dc-gpios: Display data/command selection (D/CX)
-- reset-gpios: Reset signal (RSTX)
-
-The node for this driver must be a child node of a SPI controller, hence
-all mandatory properties described in ../spi/spi-bus.txt must be specified.
-
-Optional properties:
-- rotation: panel rotation in degrees counter clockwise (0,90,180,270)
-- backlight: phandle of the backlight device attached to the panel
-
-Example:
-
- backlight: backlight {
- compatible = "gpio-backlight";
- gpios = <&gpio 44 GPIO_ACTIVE_HIGH>;
- };
-
- ...
-
- display@0{
- compatible = "jianda,jd-t18003-t01", "sitronix,st7735r";
- reg = <0>;
- spi-max-frequency = <32000000>;
- dc-gpios = <&gpio 43 GPIO_ACTIVE_HIGH>;
- reset-gpios = <&gpio 80 GPIO_ACTIVE_HIGH>;
- rotation = <270>;
- backlight = &backlight;
- };
diff --git a/Documentation/devicetree/bindings/display/sitronix,st7735r.yaml b/Documentation/devicetree/bindings/display/sitronix,st7735r.yaml
new file mode 100644
index 0000000000000000..21bccc91f74255e1
--- /dev/null
+++ b/Documentation/devicetree/bindings/display/sitronix,st7735r.yaml
@@ -0,0 +1,65 @@
+# SPDX-License-Identifier: GPL-2.0-only
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/display/sitronix,st7735r.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Sitronix ST7735R Display Panels Device Tree Bindings
+
+maintainers:
+ - David Lechner <[email protected]>
+
+description:
+ This binding is for display panels using a Sitronix ST7735R controller in
+ SPI mode.
+
+allOf:
+ - $ref: panel/panel-common.yaml#
+
+properties:
+ compatible:
+ oneOf:
+ - description:
+ Adafruit 1.8" 160x128 Color TFT LCD (Product ID 358 or 618)
+ items:
+ - enum:
+ - jianda,jd-t18003-t01
+ - const: sitronix,st7735r
+
+ spi-max-frequency:
+ maximum: 32000000
+
+ dc-gpios:
+ maxItems: 1
+ description: Display data/command selection (D/CX)
+
+required:
+ - compatible
+ - reg
+ - dc-gpios
+ - reset-gpios
+
+examples:
+ - |
+ #include <dt-bindings/gpio/gpio.h>
+
+ backlight: backlight {
+ compatible = "gpio-backlight";
+ gpios = <&gpio 44 GPIO_ACTIVE_HIGH>;
+ };
+
+ spi {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ display@0{
+ compatible = "jianda,jd-t18003-t01", "sitronix,st7735r";
+ reg = <0>;
+ spi-max-frequency = <32000000>;
+ dc-gpios = <&gpio 43 GPIO_ACTIVE_HIGH>;
+ reset-gpios = <&gpio 80 GPIO_ACTIVE_HIGH>;
+ rotation = <270>;
+ };
+ };
+
+...
diff --git a/MAINTAINERS b/MAINTAINERS
index ea8262509bdd21ac..3007f83bd504194a 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -5382,7 +5382,7 @@ M: David Lechner <[email protected]>
T: git git://anongit.freedesktop.org/drm/drm-misc
S: Maintained
F: drivers/gpu/drm/tiny/st7735r.c
-F: Documentation/devicetree/bindings/display/sitronix,st7735r.txt
+F: Documentation/devicetree/bindings/display/sitronix,st7735r.yaml

DRM DRIVER FOR SONY ACX424AKP PANELS
M: Linus Walleij <[email protected]>
--
2.17.1

2020-01-15 21:21:55

by Sam Ravnborg

[permalink] [raw]

Subject: Re: [PATCH v2 1/5] dt-bindings: display: sitronix,st7735r: Convert to DT schema

Hi Geert.

Thanks for doing the conversion to meta-schema.

On Wed, Jan 15, 2020 at 01:45:44PM +0100, Geert Uytterhoeven wrote:
> Convert the DT binding documentation for Sitronix ST7735R displays to DT
> schema.
>
> Add a reference to the Adafruit 1.8" LCD while at it.
>
> Signed-off-by: Geert Uytterhoeven <[email protected]>
> ---

> diff --git a/Documentation/devicetree/bindings/display/sitronix,st7735r.yaml b/Documentation/devicetree/bindings/display/sitronix,st7735r.yaml
> new file mode 100644
> index 0000000000000000..21bccc91f74255e1
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/display/sitronix,st7735r.yaml
> @@ -0,0 +1,65 @@
> +# SPDX-License-Identifier: GPL-2.0-only
Use (GPL-2.0-only OR BSD-2-Clause) for new binding files.

> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/display/sitronix,st7735r.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Sitronix ST7735R Display Panels Device Tree Bindings
> +
> +maintainers:
> + - David Lechner <[email protected]>
> +
> +description:
> + This binding is for display panels using a Sitronix ST7735R controller in
> + SPI mode.
> +
> +allOf:
> + - $ref: panel/panel-common.yaml#

I am no binding expert so I do not know how to add it.
But the old binding described that this MUST be a child of spi.
This is missing here.

Other panels using spi does not have it - so it is probarly OK.

So with the license fixed:
Reviewed-by: Sam Ravnborg <[email protected]>

> +
> +properties:
> + compatible:
> + oneOf:
> + - description:
> + Adafruit 1.8" 160x128 Color TFT LCD (Product ID 358 or 618)
> + items:
> + - enum:
> + - jianda,jd-t18003-t01
> + - const: sitronix,st7735r
> +
> + spi-max-frequency:
> + maximum: 32000000
> +
> + dc-gpios:
> + maxItems: 1
> + description: Display data/command selection (D/CX)
> +
> +required:
> + - compatible
> + - reg
> + - dc-gpios
> + - reset-gpios
> +
> +examples:
> + - |
> + #include <dt-bindings/gpio/gpio.h>
> +
> + backlight: backlight {
> + compatible = "gpio-backlight";
> + gpios = <&gpio 44 GPIO_ACTIVE_HIGH>;
> + };
> +
> + spi {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + display@0{
> + compatible = "jianda,jd-t18003-t01", "sitronix,st7735r";
> + reg = <0>;
> + spi-max-frequency = <32000000>;
> + dc-gpios = <&gpio 43 GPIO_ACTIVE_HIGH>;
> + reset-gpios = <&gpio 80 GPIO_ACTIVE_HIGH>;
> + rotation = <270>;
> + };
> + };
> +
> +...
> diff --git a/MAINTAINERS b/MAINTAINERS
> index ea8262509bdd21ac..3007f83bd504194a 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -5382,7 +5382,7 @@ M: David Lechner <[email protected]>
> T: git git://anongit.freedesktop.org/drm/drm-misc
> S: Maintained
> F: drivers/gpu/drm/tiny/st7735r.c
> -F: Documentation/devicetree/bindings/display/sitronix,st7735r.txt
> +F: Documentation/devicetree/bindings/display/sitronix,st7735r.yaml
>
> DRM DRIVER FOR SONY ACX424AKP PANELS
> M: Linus Walleij <[email protected]>
> --
> 2.17.1

2020-01-15 23:12:02

by Geert Uytterhoeven

[permalink] [raw]

Subject: Re: [PATCH v2 1/5] dt-bindings: display: sitronix,st7735r: Convert to DT schema

Hi Sam,

On Wed, Jan 15, 2020 at 10:01 PM Sam Ravnborg <[email protected]> wrote:
> On Wed, Jan 15, 2020 at 01:45:44PM +0100, Geert Uytterhoeven wrote:
> > Convert the DT binding documentation for Sitronix ST7735R displays to DT
> > schema.
> >
> > Add a reference to the Adafruit 1.8" LCD while at it.
> >
> > Signed-off-by: Geert Uytterhoeven <[email protected]>
> > ---
>
> > diff --git a/Documentation/devicetree/bindings/display/sitronix,st7735r.yaml b/Documentation/devicetree/bindings/display/sitronix,st7735r.yaml
> > new file mode 100644
> > index 0000000000000000..21bccc91f74255e1
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/display/sitronix,st7735r.yaml
> > @@ -0,0 +1,65 @@
> > +# SPDX-License-Identifier: GPL-2.0-only
> Use (GPL-2.0-only OR BSD-2-Clause) for new binding files.

I used GPL-2.0-only, as this is a conversion of an existing binding file,
covered by the default GPL-2.0-only of the Linux kernel source tree.

> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/display/sitronix,st7735r.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Sitronix ST7735R Display Panels Device Tree Bindings
> > +
> > +maintainers:
> > + - David Lechner <[email protected]>
> > +
> > +description:
> > + This binding is for display panels using a Sitronix ST7735R controller in
> > + SPI mode.
> > +
> > +allOf:
> > + - $ref: panel/panel-common.yaml#
>
> I am no binding expert so I do not know how to add it.
> But the old binding described that this MUST be a child of spi.
> This is missing here.
>
> Other panels using spi does not have it - so it is probarly OK.

Yeah, I couldn't find any examples of expressing that requirement in yaml.

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds

2020-01-20 16:02:15

by David Lechner

[permalink] [raw]

Subject: Re: [PATCH v2 1/5] dt-bindings: display: sitronix,st7735r: Convert to DT schema

On 1/15/20 6:45 AM, Geert Uytterhoeven wrote:
> Convert the DT binding documentation for Sitronix ST7735R displays to DT
> schema.
>
> Add a reference to the Adafruit 1.8" LCD while at it.
>
> Signed-off-by: Geert Uytterhoeven <[email protected]>
> ---
> v2:
> - New.
> ---
> .../bindings/display/sitronix,st7735r.txt | 35 ----------
> .../bindings/display/sitronix,st7735r.yaml | 65 +++++++++++++++++++
> MAINTAINERS | 2 +-
> 3 files changed, 66 insertions(+), 36 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/display/sitronix,st7735r.txt
> create mode 100644 Documentation/devicetree/bindings/display/sitronix,st7735r.yaml
>
> diff --git a/Documentation/devicetree/bindings/display/sitronix,st7735r.txt b/Documentation/devicetree/bindings/display/sitronix,st7735r.txt
> deleted file mode 100644
> index cd5c7186890a2be7..0000000000000000
> --- a/Documentation/devicetree/bindings/display/sitronix,st7735r.txt
> +++ /dev/null
> @@ -1,35 +0,0 @@
> -Sitronix ST7735R display panels
> -
> -This binding is for display panels using a Sitronix ST7735R controller in SPI
> -mode.
> -
> -Required properties:
> -- compatible: "jianda,jd-t18003-t01", "sitronix,st7735r"
> -- dc-gpios: Display data/command selection (D/CX)
> -- reset-gpios: Reset signal (RSTX)
> -
> -The node for this driver must be a child node of a SPI controller, hence
> -all mandatory properties described in ../spi/spi-bus.txt must be specified.
> -
> -Optional properties:
> -- rotation: panel rotation in degrees counter clockwise (0,90,180,270)
> -- backlight: phandle of the backlight device attached to the panel
> -
> -Example:
> -
> - backlight: backlight {
> - compatible = "gpio-backlight";
> - gpios = <&gpio 44 GPIO_ACTIVE_HIGH>;
> - };
> -
> - ...
> -
> - display@0{
> - compatible = "jianda,jd-t18003-t01", "sitronix,st7735r";
> - reg = <0>;
> - spi-max-frequency = <32000000>;
> - dc-gpios = <&gpio 43 GPIO_ACTIVE_HIGH>;
> - reset-gpios = <&gpio 80 GPIO_ACTIVE_HIGH>;
> - rotation = <270>;
> - backlight = &backlight;
> - };
> diff --git a/Documentation/devicetree/bindings/display/sitronix,st7735r.yaml b/Documentation/devicetree/bindings/display/sitronix,st7735r.yaml
> new file mode 100644
> index 0000000000000000..21bccc91f74255e1
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/display/sitronix,st7735r.yaml
> @@ -0,0 +1,65 @@
> +# SPDX-License-Identifier: GPL-2.0-only
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/display/sitronix,st7735r.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Sitronix ST7735R Display Panels Device Tree Bindings
> +
> +maintainers:
> + - David Lechner <[email protected]>
> +
> +description:
> + This binding is for display panels using a Sitronix ST7735R controller in
> + SPI mode.
> +
> +allOf:
> + - $ref: panel/panel-common.yaml#

not all of these properties are applicable.

> +
> +properties:
> + compatible:
> + oneOf:
> + - description:
> + Adafruit 1.8" 160x128 Color TFT LCD (Product ID 358 or 618)
> + items:
> + - enum:
> + - jianda,jd-t18003-t01
> + - const: sitronix,st7735r
> +
> + spi-max-frequency:
> + maximum: 32000000
> +
> + dc-gpios:
> + maxItems: 1
> + description: Display data/command selection (D/CX)
> +
> +required:
> + - compatible
> + - reg
> + - dc-gpios
> + - reset-gpios

Missing optional rotation and backlight properties.

> +
> +examples:
> + - |
> + #include <dt-bindings/gpio/gpio.h>
> +
> + backlight: backlight {
> + compatible = "gpio-backlight";
> + gpios = <&gpio 44 GPIO_ACTIVE_HIGH>;
> + };
> +
> + spi {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + display@0{
> + compatible = "jianda,jd-t18003-t01", "sitronix,st7735r";
> + reg = <0>;
> + spi-max-frequency = <32000000>;
> + dc-gpios = <&gpio 43 GPIO_ACTIVE_HIGH>;
> + reset-gpios = <&gpio 80 GPIO_ACTIVE_HIGH>;
> + rotation = <270>;
> + };
> + };
> +
> +...
> diff --git a/MAINTAINERS b/MAINTAINERS
> index ea8262509bdd21ac..3007f83bd504194a 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -5382,7 +5382,7 @@ M: David Lechner <[email protected]>
> T: git git://anongit.freedesktop.org/drm/drm-misc
> S: Maintained
> F: drivers/gpu/drm/tiny/st7735r.c
> -F: Documentation/devicetree/bindings/display/sitronix,st7735r.txt
> +F: Documentation/devicetree/bindings/display/sitronix,st7735r.yaml
>
> DRM DRIVER FOR SONY ACX424AKP PANELS
> M: Linus Walleij <[email protected]>
>

2020-01-20 19:05:00

by Sam Ravnborg

[permalink] [raw]

Subject: [PATCH] dt-bindings: restrict properties for sitronix,st7735r

Hi David.

> > +allOf:
> > + - $ref: panel/panel-common.yaml#
>
> not all of these properties are applicable.
>

> > +required:
> > + - compatible
> > + - reg
> > + - dc-gpios
> > + - reset-gpios
>
> Missing optional rotation and backlight properties.

Thanks for catching this. I have written a little .yaml files
since I applied this - and learned a little more of the syntax.

See attached patch for my attempt to fix this.
Please review.

Sam

From 6b54fb0a071c0732cd4bd5b88f456b5a85bcf4f2 Mon Sep 17 00:00:00 2001
From: Sam Ravnborg <[email protected]>
Date: Mon, 20 Jan 2020 19:55:04 +0100
Subject: [PATCH] dt-bindings: restrict properties for sitronix,st7735r

David Lechner noticed (paraphrased):
- not all properties from panel-common are applicable.
- missing optional rotation and backlight properties

Fix this by listing all allowed properties, and do not allow other properties.

Fixes: abdd9e3705c8 ("dt-bindings: display: sitronix,st7735r: Convert to DT schema")
Reported-by: David Lechner <[email protected]>
Signed-off-by: Sam Ravnborg <[email protected]>
Cc: Geert Uytterhoeven <[email protected]>
Cc: David Lechner <[email protected]>
Cc: Rob Herring <[email protected]>
Cc: [email protected]
---
.../devicetree/bindings/display/sitronix,st7735r.yaml | 7 +++++++
1 file changed, 7 insertions(+)

diff --git a/Documentation/devicetree/bindings/display/sitronix,st7735r.yaml b/Documentation/devicetree/bindings/display/sitronix,st7735r.yaml
index 8892d79e6e10..0cebaaefda03 100644
--- a/Documentation/devicetree/bindings/display/sitronix,st7735r.yaml
+++ b/Documentation/devicetree/bindings/display/sitronix,st7735r.yaml
@@ -39,12 +39,19 @@ properties:
maxItems: 1
description: Display data/command selection (D/CX)

+ backlight: true
+ reg: true
+ reset-gpios: true
+ rotation: true
+
required:
- compatible
- reg
- dc-gpios
- reset-gpios

+additionalProperties: false
+
examples:
- |
#include <dt-bindings/gpio/gpio.h>
--
2.20.1

2020-01-23 07:25:58

by Sam Ravnborg

[permalink] [raw]

Subject: Re: [PATCH] dt-bindings: restrict properties for sitronix,st7735r

On Mon, Jan 20, 2020 at 08:02:49PM +0100, Sam Ravnborg wrote:
> Hi David.
>
> > > +allOf:
> > > + - $ref: panel/panel-common.yaml#
> >
> > not all of these properties are applicable.
> >
>
> > > +required:
> > > + - compatible
> > > + - reg
> > > + - dc-gpios
> > > + - reset-gpios
> >
> > Missing optional rotation and backlight properties.
>
> Thanks for catching this. I have written a little .yaml files
> since I applied this - and learned a little more of the syntax.
>
> See attached patch for my attempt to fix this.
> Please review.

Hi David, Geert.

Any feedback on this patch?

Sam

>
> Sam
>
> >From 6b54fb0a071c0732cd4bd5b88f456b5a85bcf4f2 Mon Sep 17 00:00:00 2001
> From: Sam Ravnborg <[email protected]>
> Date: Mon, 20 Jan 2020 19:55:04 +0100
> Subject: [PATCH] dt-bindings: restrict properties for sitronix,st7735r
>
> David Lechner noticed (paraphrased):
> - not all properties from panel-common are applicable.
> - missing optional rotation and backlight properties
>
> Fix this by listing all allowed properties, and do not allow other properties.
>
> Fixes: abdd9e3705c8 ("dt-bindings: display: sitronix,st7735r: Convert to DT schema")
> Reported-by: David Lechner <[email protected]>
> Signed-off-by: Sam Ravnborg <[email protected]>
> Cc: Geert Uytterhoeven <[email protected]>
> Cc: David Lechner <[email protected]>
> Cc: Rob Herring <[email protected]>
> Cc: [email protected]
> ---
> .../devicetree/bindings/display/sitronix,st7735r.yaml | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/display/sitronix,st7735r.yaml b/Documentation/devicetree/bindings/display/sitronix,st7735r.yaml
> index 8892d79e6e10..0cebaaefda03 100644
> --- a/Documentation/devicetree/bindings/display/sitronix,st7735r.yaml
> +++ b/Documentation/devicetree/bindings/display/sitronix,st7735r.yaml
> @@ -39,12 +39,19 @@ properties:
> maxItems: 1
> description: Display data/command selection (D/CX)
>
> + backlight: true
> + reg: true
> + reset-gpios: true
> + rotation: true
> +
> required:
> - compatible
> - reg
> - dc-gpios
> - reset-gpios
>
> +additionalProperties: false
> +
> examples:
> - |
> #include <dt-bindings/gpio/gpio.h>
> --
> 2.20.1
>
> _______________________________________________
> dri-devel mailing list
> [email protected]
> https://lists.freedesktop.org/mailman/listinfo/dri-devel

2020-01-23 07:44:56

by Geert Uytterhoeven

[permalink] [raw]

Subject: Re: [PATCH] dt-bindings: restrict properties for sitronix,st7735r

Hi Sam,

On Mon, Jan 20, 2020 at 8:02 PM Sam Ravnborg <[email protected]> wrote:
> From 6b54fb0a071c0732cd4bd5b88f456b5a85bcf4f2 Mon Sep 17 00:00:00 2001
> From: Sam Ravnborg <[email protected]>
> Date: Mon, 20 Jan 2020 19:55:04 +0100
> Subject: [PATCH] dt-bindings: restrict properties for sitronix,st7735r
>
> David Lechner noticed (paraphrased):
> - not all properties from panel-common are applicable.
> - missing optional rotation and backlight properties
>
> Fix this by listing all allowed properties, and do not allow other properties.
>
> Fixes: abdd9e3705c8 ("dt-bindings: display: sitronix,st7735r: Convert to DT schema")
> Reported-by: David Lechner <[email protected]>
> Signed-off-by: Sam Ravnborg <[email protected]>

I'm far from a DT yaml expert, but LGTM, so:
Reviewed-by: Geert Uytterhoeven <[email protected]>

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds

2020-01-23 14:44:25

by Rob Herring

[permalink] [raw]

Subject: Re: [PATCH] dt-bindings: restrict properties for sitronix,st7735r

2020-01-23 18:20:48

by Sam Ravnborg

[permalink] [raw]

Subject: Re: [PATCH] dt-bindings: restrict properties for sitronix,st7735r

Hi Geert & Rob.

On Thu, Jan 23, 2020 at 08:43:39AM +0100, Geert Uytterhoeven wrote:
> Hi Sam,
>
> On Mon, Jan 20, 2020 at 8:02 PM Sam Ravnborg <[email protected]> wrote:
> > From 6b54fb0a071c0732cd4bd5b88f456b5a85bcf4f2 Mon Sep 17 00:00:00 2001
> > From: Sam Ravnborg <[email protected]>
> > Date: Mon, 20 Jan 2020 19:55:04 +0100
> > Subject: [PATCH] dt-bindings: restrict properties for sitronix,st7735r
> >
> > David Lechner noticed (paraphrased):
> > - not all properties from panel-common are applicable.
> > - missing optional rotation and backlight properties
> >
> > Fix this by listing all allowed properties, and do not allow other properties.
> >
> > Fixes: abdd9e3705c8 ("dt-bindings: display: sitronix,st7735r: Convert to DT schema")
> > Reported-by: David Lechner <[email protected]>
> > Signed-off-by: Sam Ravnborg <[email protected]>
>
> I'm far from a DT yaml expert, but LGTM, so:
> Reviewed-by: Geert Uytterhoeven <[email protected]>

Thanks, now pushed to drm-misc-next.

Sam