2015-12-08 15:25:05

by Geliang Tang

Subject: [PATCH] hfs: use list_for_each_entry in hfs_cat_delete

Use list_for_each_entry() instead of list_for_each() to simplify
the code.

Signed-off-by: Geliang Tang <[email protected]>
---
fs/hfs/catalog.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/fs/hfs/catalog.c b/fs/hfs/catalog.c
index db458ee..1eb5d41 100644
--- a/fs/hfs/catalog.c
+++ b/fs/hfs/catalog.c
@@ -214,7 +214,7 @@ int hfs_cat_delete(u32 cnid, struct inode *dir, struct qstr *str)
{
struct super_block *sb;
struct hfs_find_data fd;
- struct list_head *pos;
+ struct hfs_readdir_data *rd;
int res, type;

hfs_dbg(CAT_MOD, "delete_cat: %s,%u\n", str ? str->name : NULL, cnid);
@@ -240,9 +240,7 @@ int hfs_cat_delete(u32 cnid, struct inode *dir, struct qstr *str)
}
}

- list_for_each(pos, &HFS_I(dir)->open_dir_list) {
- struct hfs_readdir_data *rd =
- list_entry(pos, struct hfs_readdir_data, list);
+ list_for_each_entry(rd, &HFS_I(dir)->open_dir_list, list) {
if (fd.tree->keycmp(fd.search_key, (void *)&rd->key) < 0)
rd->file->f_pos--;
}
--
2.5.0

2015-12-08 17:12:05

by Viacheslav Dubeyko

Subject: Re: [PATCH] hfs: use list_for_each_entry in hfs_cat_delete

On Tue, 2015-12-08 at 23:22 +0800, Geliang Tang wrote:
> Use list_for_each_entry() instead of list_for_each() to simplify
> the code.
>

Looks good.

Reviewed-by: Vyacheslav Dubeyko <[email protected]>

Thanks,
Vyacheslav Dubeyko.

> Signed-off-by: Geliang Tang <[email protected]>
> ---
> fs/hfs/catalog.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/fs/hfs/catalog.c b/fs/hfs/catalog.c
> index db458ee..1eb5d41 100644
> --- a/fs/hfs/catalog.c
> +++ b/fs/hfs/catalog.c
> @@ -214,7 +214,7 @@ int hfs_cat_delete(u32 cnid, struct inode *dir, struct qstr *str)
> {
> struct super_block *sb;
> struct hfs_find_data fd;
> - struct list_head *pos;
> + struct hfs_readdir_data *rd;
> int res, type;
>
> hfs_dbg(CAT_MOD, "delete_cat: %s,%u\n", str ? str->name : NULL, cnid);
> @@ -240,9 +240,7 @@ int hfs_cat_delete(u32 cnid, struct inode *dir, struct qstr *str)
> }
> }
>
> - list_for_each(pos, &HFS_I(dir)->open_dir_list) {
> - struct hfs_readdir_data *rd =
> - list_entry(pos, struct hfs_readdir_data, list);
> + list_for_each_entry(rd, &HFS_I(dir)->open_dir_list, list) {
> if (fd.tree->keycmp(fd.search_key, (void *)&rd->key) < 0)
> rd->file->f_pos--;
> }