2023-04-13 19:42:57

by Andrew Halaney

Subject: [PATCH v2 1/3] arm64: dts: qcom: sa8155p-adp: Make compatible the first property

As stated at the below link in another review, compatible is always the
first property.

Follow suit here to avoid copying incorrectly in the future.

Link: https://lore.kernel.org/netdev/[email protected]/T/#ma76b4116bbb9e49ee4bcf699e40935d80965b3f3
Signed-off-by: Andrew Halaney <[email protected]>
---

Changes since v1:
* None

arch/arm64/boot/dts/qcom/sa8155p-adp.dts | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/arch/arm64/boot/dts/qcom/sa8155p-adp.dts b/arch/arm64/boot/dts/qcom/sa8155p-adp.dts
index 339fea522509..029b23198b3a 100644
--- a/arch/arm64/boot/dts/qcom/sa8155p-adp.dts
+++ b/arch/arm64/boot/dts/qcom/sa8155p-adp.dts
@@ -352,19 +352,18 @@ &ethernet {
max-speed = <1000>;

mdio {
+ compatible = "snps,dwmac-mdio";
#address-cells = <0x1>;
#size-cells = <0x0>;

- compatible = "snps,dwmac-mdio";
-
/* Micrel KSZ9031RNZ PHY */
rgmii_phy: phy@7 {
+ compatible = "ethernet-phy-ieee802.3-c22";
reg = <0x7>;

interrupt-parent = <&tlmm>;
interrupts-extended = <&tlmm 124 IRQ_TYPE_EDGE_FALLING>; /* phy intr */
device_type = "ethernet-phy";
- compatible = "ethernet-phy-ieee802.3-c22";
};
};
};
--
2.39.2

2023-04-13 19:43:05

by Andrew Halaney

Subject: [PATCH v2 2/3] arm64: dts: qcom: sa8155p-adp: Make -cells decimal

The property logically makes sense in decimal, and is the standard used
elsewhere.

Suggested-by: Konrad Dybcio <[email protected]>
Signed-off-by: Andrew Halaney <[email protected]>
---

Changes since v1:
* New patch (Konrad)

arch/arm64/boot/dts/qcom/sa8155p-adp.dts | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm64/boot/dts/qcom/sa8155p-adp.dts b/arch/arm64/boot/dts/qcom/sa8155p-adp.dts
index 029b23198b3a..ac52a8dfeba1 100644
--- a/arch/arm64/boot/dts/qcom/sa8155p-adp.dts
+++ b/arch/arm64/boot/dts/qcom/sa8155p-adp.dts
@@ -353,8 +353,8 @@ &ethernet {

mdio {
compatible = "snps,dwmac-mdio";
- #address-cells = <0x1>;
- #size-cells = <0x0>;
+ #address-cells = <1>;
+ #size-cells = <0>;

/* Micrel KSZ9031RNZ PHY */
rgmii_phy: phy@7 {
--
2.39.2

2023-04-13 19:43:24

by Andrew Halaney

Subject: [PATCH v2 3/3] arm64: dts: qcom: sa8155p-adp: Remove unneeded rgmii_phy information

Using interrupts-extended already indicates what the interrupt-parent
is, so drop the explicit interrupt-parent.

The comment about this being the phy-intr is not helpful either, since
this is the only interrupt in the phy node.

Suggested-by: Konrad Dybcio <[email protected]>
Signed-off-by: Andrew Halaney <[email protected]>
---

Changes since v1:
* New patch (Konrad)

arch/arm64/boot/dts/qcom/sa8155p-adp.dts | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/arch/arm64/boot/dts/qcom/sa8155p-adp.dts b/arch/arm64/boot/dts/qcom/sa8155p-adp.dts
index ac52a8dfeba1..b65e0203d783 100644
--- a/arch/arm64/boot/dts/qcom/sa8155p-adp.dts
+++ b/arch/arm64/boot/dts/qcom/sa8155p-adp.dts
@@ -361,8 +361,7 @@ rgmii_phy: phy@7 {
compatible = "ethernet-phy-ieee802.3-c22";
reg = <0x7>;

- interrupt-parent = <&tlmm>;
- interrupts-extended = <&tlmm 124 IRQ_TYPE_EDGE_FALLING>; /* phy intr */
+ interrupts-extended = <&tlmm 124 IRQ_TYPE_EDGE_FALLING>;
device_type = "ethernet-phy";
};
};
--
2.39.2

2023-04-13 23:38:12

by Konrad Dybcio

Subject: Re: [PATCH v2 2/3] arm64: dts: qcom: sa8155p-adp: Make -cells decimal

On 13.04.2023 21:40, Andrew Halaney wrote:
> The property logically makes sense in decimal, and is the standard used
> elsewhere.
>
> Suggested-by: Konrad Dybcio <[email protected]>
> Signed-off-by: Andrew Halaney <[email protected]>
> ---
Reviewed-by: Konrad Dybcio <[email protected]>

Konrad
>
> Changes since v1:
> * New patch (Konrad)
>
> arch/arm64/boot/dts/qcom/sa8155p-adp.dts | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sa8155p-adp.dts b/arch/arm64/boot/dts/qcom/sa8155p-adp.dts
> index 029b23198b3a..ac52a8dfeba1 100644
> --- a/arch/arm64/boot/dts/qcom/sa8155p-adp.dts
> +++ b/arch/arm64/boot/dts/qcom/sa8155p-adp.dts
> @@ -353,8 +353,8 @@ &ethernet {
>
> mdio {
> compatible = "snps,dwmac-mdio";
> - #address-cells = <0x1>;
> - #size-cells = <0x0>;
> + #address-cells = <1>;
> + #size-cells = <0>;
>
> /* Micrel KSZ9031RNZ PHY */
> rgmii_phy: phy@7 {

2023-04-13 23:39:00

by Konrad Dybcio

Subject: Re: [PATCH v2 1/3] arm64: dts: qcom: sa8155p-adp: Make compatible the first property

On 13.04.2023 21:40, Andrew Halaney wrote:
> As stated at the below link in another review, compatible is always the
> first property.
>
> Follow suit here to avoid copying incorrectly in the future.
>
> Link: https://lore.kernel.org/netdev/[email protected]/T/#ma76b4116bbb9e49ee4bcf699e40935d80965b3f3
> Signed-off-by: Andrew Halaney <[email protected]>
> ---
Reviewed-by: Konrad Dybcio <[email protected]>

Konrad
>
> Changes since v1:
> * None
>
> arch/arm64/boot/dts/qcom/sa8155p-adp.dts | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sa8155p-adp.dts b/arch/arm64/boot/dts/qcom/sa8155p-adp.dts
> index 339fea522509..029b23198b3a 100644
> --- a/arch/arm64/boot/dts/qcom/sa8155p-adp.dts
> +++ b/arch/arm64/boot/dts/qcom/sa8155p-adp.dts
> @@ -352,19 +352,18 @@ &ethernet {
> max-speed = <1000>;
>
> mdio {
> + compatible = "snps,dwmac-mdio";
> #address-cells = <0x1>;
> #size-cells = <0x0>;
>
> - compatible = "snps,dwmac-mdio";
> -
> /* Micrel KSZ9031RNZ PHY */
> rgmii_phy: phy@7 {
> + compatible = "ethernet-phy-ieee802.3-c22";
> reg = <0x7>;
>
> interrupt-parent = <&tlmm>;
> interrupts-extended = <&tlmm 124 IRQ_TYPE_EDGE_FALLING>; /* phy intr */
> device_type = "ethernet-phy";
> - compatible = "ethernet-phy-ieee802.3-c22";
> };
> };
> };

2023-04-13 23:42:59

by Konrad Dybcio

Subject: Re: [PATCH v2 3/3] arm64: dts: qcom: sa8155p-adp: Remove unneeded rgmii_phy information

On 13.04.2023 21:40, Andrew Halaney wrote:
> Using interrupts-extended already indicates what the interrupt-parent
> is, so drop the explicit interrupt-parent.
>
> The comment about this being the phy-intr is not helpful either, since
> this is the only interrupt in the phy node.
>
> Suggested-by: Konrad Dybcio <[email protected]>
> Signed-off-by: Andrew Halaney <[email protected]>
> ---
Reviewed-by: Konrad Dybcio <[email protected]>

Konrad
>
> Changes since v1:
> * New patch (Konrad)
>
> arch/arm64/boot/dts/qcom/sa8155p-adp.dts | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sa8155p-adp.dts b/arch/arm64/boot/dts/qcom/sa8155p-adp.dts
> index ac52a8dfeba1..b65e0203d783 100644
> --- a/arch/arm64/boot/dts/qcom/sa8155p-adp.dts
> +++ b/arch/arm64/boot/dts/qcom/sa8155p-adp.dts
> @@ -361,8 +361,7 @@ rgmii_phy: phy@7 {
> compatible = "ethernet-phy-ieee802.3-c22";
> reg = <0x7>;
>
> - interrupt-parent = <&tlmm>;
> - interrupts-extended = <&tlmm 124 IRQ_TYPE_EDGE_FALLING>; /* phy intr */
> + interrupts-extended = <&tlmm 124 IRQ_TYPE_EDGE_FALLING>;
> device_type = "ethernet-phy";
> };
> };