2009-11-09 12:52:30

by Simon Arlott

[permalink] [raw]
Subject: Re: [PATCH 70/75] cxacru: declare MODULE_FIRMWARE

On Sat, November 7, 2009 22:19, Ben Hutchings wrote:
> On Sat, 2009-11-07 at 22:16 +0000, Simon Arlott wrote:
>> On 07/11/09 22:09, Ben Hutchings wrote:
>> > +++ b/drivers/usb/atm/cxacru.c
>> > +MODULE_FIRMWARE("cxacru-fw.bin");
>> > +MODULE_FIRMWARE("cxacru-bp.bin");
>>
>> It also optionally loads "cxacru-cf.bin".
>
> I saw that, but thought it better not to list optional files.

In that case, "cxacru-bp.bin" is optional as only certain versions
of the device require it.

Perhaps MODULE_FIRMWARE() should have an "optional" flag too, so
that all files can be listed?

--
Simon Arlott