From: Randy Dunlap <[email protected]>
A user reported:
'Use of uninitialized value $ENV{"LMC_KEEP"} in split at
./scripts/kconfig/streamline_config.pl line 596.'
so first check that $ENV{LMC_KEEP} is defined before trying
to use it.
Fixes: c027b02d89fd ("streamline_config.pl: add LMC_KEEP to preserve some kconfigs")
Signed-off-by: Randy Dunlap <[email protected]>
Cc: Changbin Du <[email protected]>
Cc: Steven Rostedt (VMware) <[email protected]>
Cc: Masahiro Yamada <[email protected]>
Acked-by: Steven Rostedt (VMware) <[email protected]>
---
scripts/kconfig/streamline_config.pl | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
--- linux-next-20200825.orig/scripts/kconfig/streamline_config.pl
+++ linux-next-20200825/scripts/kconfig/streamline_config.pl
@@ -593,7 +593,10 @@ while ($repeat) {
}
my %setconfigs;
-my @preserved_kconfigs = split(/:/,$ENV{LMC_KEEP});
+my @preserved_kconfigs;
+if (defined($ENV{'LMC_KEEP'})) {
+ @preserved_kconfigs = split(/:/,$ENV{LMC_KEEP});
+}
sub in_preserved_kconfigs {
my $kconfig = $config2kfile{$_[0]};
On Thu, Aug 27, 2020 at 6:21 AM Randy Dunlap <[email protected]> wrote:
>
> From: Randy Dunlap <[email protected]>
>
> A user reported:
> 'Use of uninitialized value $ENV{"LMC_KEEP"} in split at
> ./scripts/kconfig/streamline_config.pl line 596.'
>
> so first check that $ENV{LMC_KEEP} is defined before trying
> to use it.
>
> Fixes: c027b02d89fd ("streamline_config.pl: add LMC_KEEP to preserve some kconfigs")
> Signed-off-by: Randy Dunlap <[email protected]>
> Cc: Changbin Du <[email protected]>
> Cc: Steven Rostedt (VMware) <[email protected]>
> Cc: Masahiro Yamada <[email protected]>
> Acked-by: Steven Rostedt (VMware) <[email protected]>
> ---
Applied to linux-kbuild/fixes with Nathan's tag
Reported-by: Nathan Royce <[email protected]>
Nathan,
I think adding your tag is OK to credit your contribution.
Please let me know if you do not have it in
the commit log.
> scripts/kconfig/streamline_config.pl | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> --- linux-next-20200825.orig/scripts/kconfig/streamline_config.pl
> +++ linux-next-20200825/scripts/kconfig/streamline_config.pl
> @@ -593,7 +593,10 @@ while ($repeat) {
> }
>
> my %setconfigs;
> -my @preserved_kconfigs = split(/:/,$ENV{LMC_KEEP});
> +my @preserved_kconfigs;
> +if (defined($ENV{'LMC_KEEP'})) {
> + @preserved_kconfigs = split(/:/,$ENV{LMC_KEEP});
> +}
>
> sub in_preserved_kconfigs {
> my $kconfig = $config2kfile{$_[0]};
>
--
Best Regards
Masahiro Yamada
Thanks, but I'd just as soon not be acknowledged/credited. All I did
was submit a report.
On Wed, Sep 2, 2020 at 11:47 AM Masahiro Yamada <[email protected]> wrote:
>
> Applied to linux-kbuild/fixes with Nathan's tag
>
> Reported-by: Nathan Royce <[email protected]>
>
>
>
> Nathan,
> I think adding your tag is OK to credit your contribution.
> Please let me know if you do not have it in
> the commit log.
>
>
>
> --
> Best Regards
> Masahiro Yamada
On Thu, Sep 3, 2020 at 3:22 AM Nathan Royce <[email protected]> wrote:
>
> Thanks, but I'd just as soon not be acknowledged/credited. All I did
> was submit a report.
>
> On Wed, Sep 2, 2020 at 11:47 AM Masahiro Yamada <[email protected]> wrote:
> >
> > Applied to linux-kbuild/fixes with Nathan's tag
> >
> > Reported-by: Nathan Royce <[email protected]>
> >
> >
> >
> > Nathan,
> > I think adding your tag is OK to credit your contribution.
> > Please let me know if you do not have it in
> > the commit log.
Even if you do not write the code,
reporting bugs is a great contribution,
and the Reported-by exists for that, I think.
So, I just want to add your Reported-by tag
(if you do not mind).
--
Best Regards
Masahiro Yamada
Heard, but all the same if it isn't important (which I'm assuming),
I'd just as soon be left out of it. That's just the way I am in
general, not wanting to be seen unless I have to be seen. Thanks
though.
On Wed, Sep 2, 2020 at 9:14 PM Masahiro Yamada <[email protected]> wrote:
>
> Even if you do not write the code,
> reporting bugs is a great contribution,
> and the Reported-by exists for that, I think.
>
> So, I just want to add your Reported-by tag
> (if you do not mind).
>
>
> --
> Best Regards
> Masahiro Yamada
On Thu, Sep 3, 2020 at 11:18 AM Nathan Royce <[email protected]> wrote:
>
> Heard, but all the same if it isn't important (which I'm assuming),
> I'd just as soon be left out of it. That's just the way I am in
> general, not wanting to be seen unless I have to be seen. Thanks
> though.
OK, I will drop your tag.
--
Best Regards
Masahiro Yamada