2023-07-28 10:50:21

by Varshini Rajendran

Subject: [PATCH v3 28/50] dt-bindings: watchdog: sama5d4-wdt: add compatible for sam9x7-wdt

Add compatible microchip,sam9x7-wdt to DT bindings documentation.

Signed-off-by: Varshini Rajendran <[email protected]>
---
.../bindings/watchdog/atmel,sama5d4-wdt.yaml | 15 +++++++++++----
1 file changed, 11 insertions(+), 4 deletions(-)

diff --git a/Documentation/devicetree/bindings/watchdog/atmel,sama5d4-wdt.yaml b/Documentation/devicetree/bindings/watchdog/atmel,sama5d4-wdt.yaml
index 816f85ee2c77..ce3d046e7244 100644
--- a/Documentation/devicetree/bindings/watchdog/atmel,sama5d4-wdt.yaml
+++ b/Documentation/devicetree/bindings/watchdog/atmel,sama5d4-wdt.yaml
@@ -14,10 +14,17 @@ allOf:

properties:
compatible:
- enum:
- - atmel,sama5d4-wdt
- - microchip,sam9x60-wdt
- - microchip,sama7g5-wdt
+ oneOf:
+ - items:
+ - enum:
+ - atmel,sama5d4-wdt
+ - microchip,sam9x60-wdt
+ - microchip,sama7g5-wdt
+ - items:
+ - enum:
+ - microchip,sam9x7-wdt
+ - enum:
+ - microchip,sam9x60-wdt

reg:
maxItems: 1
--
2.25.1

2023-07-28 13:49:21

by Krzysztof Kozlowski

Subject: Re: [PATCH v3 28/50] dt-bindings: watchdog: sama5d4-wdt: add compatible for sam9x7-wdt

On 28/07/2023 12:28, Varshini Rajendran wrote:
> Add compatible microchip,sam9x7-wdt to DT bindings documentation.
>
> Signed-off-by: Varshini Rajendran <[email protected]>
> ---
> .../bindings/watchdog/atmel,sama5d4-wdt.yaml | 15 +++++++++++----
> 1 file changed, 11 insertions(+), 4 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/watchdog/atmel,sama5d4-wdt.yaml b/Documentation/devicetree/bindings/watchdog/atmel,sama5d4-wdt.yaml
> index 816f85ee2c77..ce3d046e7244 100644
> --- a/Documentation/devicetree/bindings/watchdog/atmel,sama5d4-wdt.yaml
> +++ b/Documentation/devicetree/bindings/watchdog/atmel,sama5d4-wdt.yaml
> @@ -14,10 +14,17 @@ allOf:
>
> properties:
> compatible:
> - enum:
> - - atmel,sama5d4-wdt
> - - microchip,sam9x60-wdt
> - - microchip,sama7g5-wdt
> + oneOf:
> + - items:

Drop items.

> + - enum:
> + - atmel,sama5d4-wdt
> + - microchip,sam9x60-wdt
> + - microchip,sama7g5-wdt
> + - items:
> + - enum:
> + - microchip,sam9x7-wdt
> + - enum:

Not an enum.

It is surprising how the same change look different between two of your
patches.


Best regards,
Krzysztof