2020-01-21 03:44:35

by Alex Shi

Subject: [PATCH] OCFS2: remove dlm_lock_is_remote

This macros is also not used from it was introduced. better to remove
it.

Signed-off-by: Alex Shi <[email protected]>
Cc: Mark Fasheh <[email protected]>
Cc: Joel Becker <[email protected]>
Cc: Joseph Qi <[email protected]>
Cc: Kate Stewart <[email protected]>
Cc: Greg Kroah-Hartman <[email protected]>
Cc: Thomas Gleixner <[email protected]>
Cc: Richard Fontana <[email protected]>
Cc: [email protected]
Cc: [email protected]
---
fs/ocfs2/dlm/dlmthread.c | 2 --
1 file changed, 2 deletions(-)

diff --git a/fs/ocfs2/dlm/dlmthread.c b/fs/ocfs2/dlm/dlmthread.c
index 2dd9727537fe..0da9ffc40a88 100644
--- a/fs/ocfs2/dlm/dlmthread.c
+++ b/fs/ocfs2/dlm/dlmthread.c
@@ -39,8 +39,6 @@
static int dlm_thread(void *data);
static void dlm_flush_asts(struct dlm_ctxt *dlm);

-#define dlm_lock_is_remote(dlm, lock) ((lock)->ml.node != (dlm)->node_num)
-
/* will exit holding res->spinlock, but may drop in function */
/* waits until flags are cleared on res->state */
void __dlm_wait_on_lockres_flags(struct dlm_lock_resource *res, int flags)
--
1.8.3.1

2020-01-26 01:49:48

by Joseph Qi

Subject: Re: [PATCH] OCFS2: remove dlm_lock_is_remote

On 20/1/21 11:43, Alex Shi wrote:
> This macros is also not used from it was introduced. better to remove
> it.
>
> Signed-off-by: Alex Shi <[email protected]>
> Cc: Mark Fasheh <[email protected]>
> Cc: Joel Becker <[email protected]>
> Cc: Joseph Qi <[email protected]>
> Cc: Kate Stewart <[email protected]>
> Cc: Greg Kroah-Hartman <[email protected]>
> Cc: Thomas Gleixner <[email protected]>
> Cc: Richard Fontana <[email protected]>
> Cc: [email protected]
> Cc: [email protected]

Acked-by: Joseph Qi <[email protected]>
> ---
> fs/ocfs2/dlm/dlmthread.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/fs/ocfs2/dlm/dlmthread.c b/fs/ocfs2/dlm/dlmthread.c
> index 2dd9727537fe..0da9ffc40a88 100644
> --- a/fs/ocfs2/dlm/dlmthread.c
> +++ b/fs/ocfs2/dlm/dlmthread.c
> @@ -39,8 +39,6 @@
> static int dlm_thread(void *data);
> static void dlm_flush_asts(struct dlm_ctxt *dlm);
>
> -#define dlm_lock_is_remote(dlm, lock) ((lock)->ml.node != (dlm)->node_num)
> -
> /* will exit holding res->spinlock, but may drop in function */
> /* waits until flags are cleared on res->state */
> void __dlm_wait_on_lockres_flags(struct dlm_lock_resource *res, int flags)
>