2021-05-21 02:23:55

by Christian König

[permalink] [raw]
Subject: Re: [PATCH 20/38] drm/radeon/radeon_vm: Fix function naming disparities

Am 20.05.21 um 14:02 schrieb Lee Jones:
> Fixes the following W=1 kernel build warning(s):
>
> drivers/gpu/drm/radeon/radeon_vm.c:61: warning: expecting prototype for radeon_vm_num_pde(). Prototype was for radeon_vm_num_pdes() instead
> drivers/gpu/drm/radeon/radeon_vm.c:642: warning: expecting prototype for radeon_vm_update_pdes(). Prototype was for radeon_vm_update_page_directory() instead
>
> Cc: Alex Deucher <[email protected]>
> Cc: "Christian König" <[email protected]>
> Cc: David Airlie <[email protected]>
> Cc: Daniel Vetter <[email protected]>
> Cc: [email protected]
> Cc: [email protected]
> Signed-off-by: Lee Jones <[email protected]>

Reviewed-by: Christian König <[email protected]>

> ---
> drivers/gpu/drm/radeon/radeon_vm.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/radeon/radeon_vm.c b/drivers/gpu/drm/radeon/radeon_vm.c
> index 2dc9c9f98049b..36a38adaaea96 100644
> --- a/drivers/gpu/drm/radeon/radeon_vm.c
> +++ b/drivers/gpu/drm/radeon/radeon_vm.c
> @@ -51,7 +51,7 @@
> */
>
> /**
> - * radeon_vm_num_pde - return the number of page directory entries
> + * radeon_vm_num_pdes - return the number of page directory entries
> *
> * @rdev: radeon_device pointer
> *
> @@ -626,7 +626,7 @@ static uint32_t radeon_vm_page_flags(uint32_t flags)
> }
>
> /**
> - * radeon_vm_update_pdes - make sure that page directory is valid
> + * radeon_vm_update_page_directory - make sure that page directory is valid
> *
> * @rdev: radeon_device pointer
> * @vm: requested vm


2021-05-21 07:10:09

by Alex Deucher

[permalink] [raw]
Subject: Re: [PATCH 20/38] drm/radeon/radeon_vm: Fix function naming disparities

Applied. Thanks!


On Thu, May 20, 2021 at 8:05 AM Christian König
<[email protected]> wrote:
>
> Am 20.05.21 um 14:02 schrieb Lee Jones:
> > Fixes the following W=1 kernel build warning(s):
> >
> > drivers/gpu/drm/radeon/radeon_vm.c:61: warning: expecting prototype for radeon_vm_num_pde(). Prototype was for radeon_vm_num_pdes() instead
> > drivers/gpu/drm/radeon/radeon_vm.c:642: warning: expecting prototype for radeon_vm_update_pdes(). Prototype was for radeon_vm_update_page_directory() instead
> >
> > Cc: Alex Deucher <[email protected]>
> > Cc: "Christian König" <[email protected]>
> > Cc: David Airlie <[email protected]>
> > Cc: Daniel Vetter <[email protected]>
> > Cc: [email protected]
> > Cc: [email protected]
> > Signed-off-by: Lee Jones <[email protected]>
>
> Reviewed-by: Christian König <[email protected]>
>
> > ---
> > drivers/gpu/drm/radeon/radeon_vm.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/radeon/radeon_vm.c b/drivers/gpu/drm/radeon/radeon_vm.c
> > index 2dc9c9f98049b..36a38adaaea96 100644
> > --- a/drivers/gpu/drm/radeon/radeon_vm.c
> > +++ b/drivers/gpu/drm/radeon/radeon_vm.c
> > @@ -51,7 +51,7 @@
> > */
> >
> > /**
> > - * radeon_vm_num_pde - return the number of page directory entries
> > + * radeon_vm_num_pdes - return the number of page directory entries
> > *
> > * @rdev: radeon_device pointer
> > *
> > @@ -626,7 +626,7 @@ static uint32_t radeon_vm_page_flags(uint32_t flags)
> > }
> >
> > /**
> > - * radeon_vm_update_pdes - make sure that page directory is valid
> > + * radeon_vm_update_page_directory - make sure that page directory is valid
> > *
> > * @rdev: radeon_device pointer
> > * @vm: requested vm
>
> _______________________________________________
> amd-gfx mailing list
> [email protected]
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx