Hi Sergey,
> In expand_inode_data(), the 'new_size' local variable is initialized to
> the result of i_size_read(), however this value isn't ever used, so we
> can drop this initializer...
>
> Found by Linux Verification Center (linuxtesting.org) with the SVACE static
> analysis tool.
>
> Signed-off-by: Sergey Shtylyov <[email protected]>
>
> ---
> This patch is against the 'dev' branch of Jaegeuk Kim's F2FS repo...
> Reposting with ISP RAS mailing lists CC'ed now...
Why do you repeatedly send a patch that cannot be applied, and this does not have
a CC on linux-kernel.vger.kernel.org.
Otherwise, code modification looks good to me.
Thx,
Yangtao
Hi all,
On 2022/12/21 11:30, Yangtao Li wrote:
> Hi Sergey,
>
>> In expand_inode_data(), the 'new_size' local variable is initialized to
>> the result of i_size_read(), however this value isn't ever used, so we
>> can drop this initializer...
>>
>> Found by Linux Verification Center (linuxtesting.org) with the SVACE static
>> analysis tool.
>>
>> Signed-off-by: Sergey Shtylyov <[email protected]>
>>
>> ---
>> This patch is against the 'dev' branch of Jaegeuk Kim's F2FS repo...
>> Reposting with ISP RAS mailing lists CC'ed now...
>
> Why do you repeatedly send a patch that cannot be applied, and this does not have
The format is weired, but still I can apply this into my git repo...
> a CC on linux-kernel.vger.kernel.org.
I guess linux-kernel.vger.kernel.org is not mandatory, feel free
to Cc this mailing list.
Thanks,
>
> Otherwise, code modification looks good to me.
>
> Thx,
> Yangtao
Hello!
On 12/21/22 6:30 AM, Yangtao Li wrote:
>> In expand_inode_data(), the 'new_size' local variable is initialized to
>> the result of i_size_read(), however this value isn't ever used, so we
>> can drop this initializer...
>>
>> Found by Linux Verification Center (linuxtesting.org) with the SVACE static
>> analysis tool.
>>
>> Signed-off-by: Sergey Shtylyov <[email protected]>
>>
>> ---
>> This patch is against the 'dev' branch of Jaegeuk Kim's F2FS repo...
>> Reposting with ISP RAS mailing lists CC'ed now...
>
> Why do you repeatedly send a patch that cannot be applied,
Why (it does apply to your 'dev' branch)? Because of the merge window?
> and this does not have a CC on linux-kernel.vger.kernel.org.
I normnally avoid CCing LKML as my patches are not generally interesting
to the wide public (I think)...
> Otherwise, code modification looks good to me.
Thanx!
> Thx,
> Yangtao
MBR, Sergey
On 12/21/22 3:34 PM, Chao Yu wrote:
[...]
>>> In expand_inode_data(), the 'new_size' local variable is initialized to
>>> the result of i_size_read(), however this value isn't ever used, so we
>>> can drop this initializer...
>>>
>>> Found by Linux Verification Center (linuxtesting.org) with the SVACE static
>>> analysis tool.
>>>
>>> Signed-off-by: Sergey Shtylyov <[email protected]>
>>>
>>> ---
>>> This patch is against the 'dev' branch of Jaegeuk Kim's F2FS repo...
>>> Reposting with ISP RAS mailing lists CC'ed now...
>>
>> Why do you repeatedly send a patch that cannot be applied, and this does not have
>
> The format is weired, but still I can apply this into my git repo...
This is just the quilt's format. I normally use quilt for development
and then import my patch seies to git in order to prepare it for posting.
If I post a single patch, I just skip the git step and post with my MTA...
[...]
>> Thx,
>> Yangtao
MBR, Sergey